Bug 158591 - Rare failure in stress/v8-deltablue-strict.js.ftl-eager
Summary: Rare failure in stress/v8-deltablue-strict.js.ftl-eager
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-06-09 16:01 PDT by Filip Pizlo
Modified: 2016-06-09 19:02 PDT (History)
5 users (show)

See Also:


Attachments
the patch (12.20 KB, patch)
2016-06-09 16:20 PDT, Filip Pizlo
saam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2016-06-09 16:01:49 PDT
Patch forthcoming.
Comment 1 Filip Pizlo 2016-06-09 16:20:50 PDT
Created attachment 280964 [details]
the patch
Comment 2 Saam Barati 2016-06-09 16:33:55 PDT
Comment on attachment 280964 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=280964&action=review

> Source/JavaScriptCore/dfg/DFGNode.h:546
> +    void convertToPutByOffset(StorageAccessData& data, Edge storage, Edge childEdge)

I'd call this base
Comment 3 Filip Pizlo 2016-06-09 18:56:47 PDT
(In reply to comment #2)
> Comment on attachment 280964 [details]
> the patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=280964&action=review
> 
> > Source/JavaScriptCore/dfg/DFGNode.h:546
> > +    void convertToPutByOffset(StorageAccessData& data, Edge storage, Edge childEdge)
> 
> I'd call this base

Fixed!
Comment 4 Filip Pizlo 2016-06-09 19:02:22 PDT
Landed in http://trac.webkit.org/changeset/201900