Bug 158588 - Clean up EditorClient lifetime
Summary: Clean up EditorClient lifetime
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords:
Depends on: 158609
Blocks:
  Show dependency tree / graph
 
Reported: 2016-06-09 15:37 PDT by Alex Christensen
Modified: 2016-06-09 23:43 PDT (History)
3 users (show)

See Also:

Attachments
Patch (33.88 KB, patch)
2016-06-09 15:47 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (18.50 KB, patch)
2016-06-09 16:23 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (18.46 KB, patch)
2016-06-09 16:32 PDT, Alex Christensen 		andersca: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2016-06-09 15:37:18 PDT 
Clean up EditorClient lifetime
Comment 1 Alex Christensen 2016-06-09 15:47:12 PDT 
Created attachment 280960 [details]
Patch
Comment 2 Alex Christensen 2016-06-09 16:23:04 PDT 
Created attachment 280966 [details]
Patch
Comment 3 Alex Christensen 2016-06-09 16:32:20 PDT 
Created attachment 280967 [details]
Patch
Comment 4 Alex Christensen 2016-06-09 16:53:51 PDT 
http://trac.webkit.org/changeset/201894
Comment 5 WebKit Commit Bot 2016-06-09 22:10:45 PDT 
Re-opened since this is blocked by bug 158609
Comment 6 Ryan Haddad 2016-06-09 22:12:19 PDT 
This change appears to have broken the Windows build.

https://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/78309/steps/compile-webkit/logs/stdio
Comment 7 Alex Christensen 2016-06-09 22:17:09 PDT 
I guess I didn't wait for all the EWS bots :(
http://trac.webkit.org/changeset/201905 fixed it.
Comment 8 Alex Christensen 2016-06-09 22:33:41 PDT 
and r201909
Comment 9 Alexey Proskuryakov 2016-06-09 23:43:05 PDT 
I wonder if this fixed bug 158401!