Bug 158584 - Web Inspector: heap snapshot comparison view shows nothing if later snapshot is chosen first
Summary: Web Inspector: heap snapshot comparison view shows nothing if later snapshot ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Matt Baker
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-06-09 14:31 PDT by Brian Burg
Modified: 2016-06-10 19:10 PDT (History)
7 users (show)

See Also:


Attachments
Comparing 3 to 5 (113.60 KB, image/png)
2016-06-09 14:31 PDT, Brian Burg
no flags Details
Comparing 5 to 3 (83.45 KB, image/png)
2016-06-09 14:32 PDT, Brian Burg
no flags Details
[Patch] Proposed Fix (2.78 KB, patch)
2016-06-10 14:33 PDT, Matt Baker
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Burg 2016-06-09 14:31:45 PDT
Created attachment 280949 [details]
Comparing 3 to 5

This is really confusing and looks like a bug. Maybe it should always sort the comparison to put earlier first. I can't think of a use case for actually showing the diff in reverse.
Comment 1 Brian Burg 2016-06-09 14:32:04 PDT
Created attachment 280950 [details]
Comparing 5 to 3
Comment 2 Radar WebKit Bug Importer 2016-06-09 14:32:40 PDT
<rdar://problem/26727849>
Comment 3 Radar WebKit Bug Importer 2016-06-09 14:37:07 PDT
<rdar://problem/26727887>
Comment 4 Matt Baker 2016-06-10 14:33:00 PDT
Created attachment 281047 [details]
[Patch] Proposed Fix
Comment 5 WebKit Commit Bot 2016-06-10 16:04:21 PDT
Comment on attachment 281047 [details]
[Patch] Proposed Fix

Clearing flags on attachment: 281047

Committed r201949: <http://trac.webkit.org/changeset/201949>
Comment 6 WebKit Commit Bot 2016-06-10 16:04:25 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Joseph Pecoraro 2016-06-10 17:26:29 PDT
Comment on attachment 281047 [details]
[Patch] Proposed Fix

Nice fix. This is exactly what I would have done.
Comment 8 Brian Burg 2016-06-10 19:10:04 PDT
(In reply to comment #7)
> Comment on attachment 281047 [details]
> [Patch] Proposed Fix
> 
> Nice fix. This is exactly what I would have done.

Wohoo! Thanks.