Bug 158579 – Web Inspector: Support Command-P for quick open

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Timothy Hatcher]

To match Chrome Dev Tools, we should support Command-P. This is a stupid shortcut, since Command-P is normally Print. But I have seen some users on Twitter not know we supported Quick Open because the shortcut was different.

[Nikita Vasilyev]

Command-P also matches Sublime Text and Atom, which
is probably why Chrome DevTools chose to use it.

[Radar WebKit Bug Importer]

<rdar://problem/26726751>

[Radar WebKit Bug Importer]

<rdar://problem/26726702>

[Nikita Vasilyev]

Created attachment 280957 [details]
Patch

[Nikita Vasilyev]

View in context: https://bugs.webkit.org/attachment.cgi?id=280957&action=review

> Source/WebInspectorUI/UserInterface/Base/Main.js:261
>      this.openResourceKeyboardShortcut = new WebInspector.KeyboardShortcut(WebInspector.KeyboardShortcut.Modifier.Command | WebInspector.KeyboardShortcut.Modifier.Shift, "O", this._showOpenResourceDialog.bind(this));

This property is never used, not even in tests. Why do we use it? Same goes for many other WebInspector._*Shortcut properties.

[WebKit Commit Bot]

Comment on attachment 280957 [details]
Patch

Clearing flags on attachment: 280957

Committed r201891: <http://trac.webkit.org/changeset/201891>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Darin Adler]

Comment on attachment 280957 [details]
Patch

Isn’t command-P usually Print?

[Blaze Burg]

(In reply to comment #8)
> Comment on attachment 280957 [details]
> Patch
> 
> Isn’t command-P usually Print?

That is often the case, but not always. Previously it was not bound to anything for the Web Inspector window. Xcode and Instruments do not bind it to anything. I don't think there is anything to print in the inspector window itself.

I don't like to use such a prime shortcut that conflicts with Print, but our hands are a bit tied since we don't have our own menu bar / key equivalents that can be targeted by Keyboard pref pane's App Shortcuts. So we have to do what the user is going to expect, which due to Sublime Text's precedent, is command palette or quick open.