Bug 158576 – atob() / btoa() API should be exposed to workers

• Status: RESOLVED
• Resolution: FIXED
• Component: Bindings

[Chris Dumez]

atob() / btoa() API should be exposed to workers:
https://html.spec.whatwg.org/multipage/webappapis.html#windoworworkerglobalscope

[Chris Dumez]

Test:
http://w3c-test.org/workers/interfaces.worker

[Radar WebKit Bug Importer]

<rdar://problem/26729340>

[Chris Dumez]

Created attachment 280958 [details]
Patch

[Chris Dumez]

*** Bug 55663 has been marked as a duplicate of this bug. ***

[WebKit Commit Bot]

Comment on attachment 280958 [details]
Patch

Clearing flags on attachment: 280958

Committed r201898: <http://trac.webkit.org/changeset/201898>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Darin Adler]

Comment on attachment 280958 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=280958&action=review

> Source/WebCore/page/Base64Utilities.h:36
> +    Base64Utilities() = default;
> +

We should just delete these two lines of code. This is what a class gets if you don’t explicitly define a constructor. We should do this only if we want to make the default constructor private or protected.

[Chris Dumez]

Comment on attachment 280958 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=280958&action=review

>> Source/WebCore/page/Base64Utilities.h:36
>> +
> 
> We should just delete these two lines of code. This is what a class gets if you don’t explicitly define a constructor. We should do this only if we want to make the default constructor private or protected.

My bad. I'll drop them in a follow up.

[Darin Adler]

Comment on attachment 280958 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=280958&action=review

> Source/WebCore/page/Base64Utilities.h:38
> +    String btoa(const String& stringToEncode, ExceptionCode&);
> +    String atob(const String& encodedString, ExceptionCode&);

Another thing: These should both be static member functions. More efficient that way. Neither makes any use of "this", directly or indirectly.

[Chris Dumez]

Committed r201903: <http://trac.webkit.org/changeset/201903>