Bug 158568 - WorkerGlobalScope attributes / operations should be on the prototype
Summary: WorkerGlobalScope attributes / operations should be on the prototype
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Bindings (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar, WebExposed
Depends on:
Blocks:
 
Reported: 2016-06-09 08:55 PDT by Chris Dumez
Modified: 2016-06-09 11:45 PDT (History)
8 users (show)

See Also:


Attachments
Patch (8.42 KB, patch)
2016-06-09 10:19 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2016-06-09 08:55:45 PDT
WorkerGlobalScope attributes / operations should be on the prototype because WorkerGlobalScope is not marked as [Global] / [PrimaryGlobal]:
- https://html.spec.whatwg.org/multipage/workers.html#the-workerglobalscope-common-interface
- http://heycam.github.io/webidl/#es-attributes
- http://heycam.github.io/webidl/#es-operations

DedicatedWorkerGlobalScope is the interface that is marked as [Global] and whose attributes / operations should be on the instance.

Test:
http://w3c-test.org/workers/interfaces.worker
Comment 1 Chris Dumez 2016-06-09 09:13:13 PDT
Fixing this bring the number of failures on http://w3c-test.org/workers/interfaces.worker from 65 to 34. It also fixes 1 failure on the corresponding IndexedDB in workers test.
Comment 2 Radar WebKit Bug Importer 2016-06-09 09:18:22 PDT
<rdar://problem/26720079>
Comment 3 Chris Dumez 2016-06-09 10:19:03 PDT
Created attachment 280926 [details]
Patch
Comment 4 Geoffrey Garen 2016-06-09 11:44:41 PDT
Comment on attachment 280926 [details]
Patch

r=me
Comment 5 Chris Dumez 2016-06-09 11:45:51 PDT
Comment on attachment 280926 [details]
Patch

Clearing flags on attachment: 280926

Committed r201876: <http://trac.webkit.org/changeset/201876>
Comment 6 Chris Dumez 2016-06-09 11:45:57 PDT
All reviewed patches have been landed.  Closing bug.