Bug 158562 - [Threaded Compositor] Make it clear that compositing thread operations are always scheduled from the main thread
Summary: [Threaded Compositor] Make it clear that compositing thread operations are al...
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Keywords: Gtk
Depends on:
Blocks: 154070
  Show dependency treegraph
Reported: 2016-06-09 05:11 PDT by Carlos Garcia Campos
Modified: 2016-06-10 05:51 PDT (History)
4 users (show)

See Also:

Patch (9.25 KB, patch)
2016-06-09 05:18 PDT, Carlos Garcia Campos
zan: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2016-06-09 05:11:52 PDT
The code is written as if the compositor thread could also call callOnCompositingRunLoop() which makes the code confusing.
Comment 1 Carlos Garcia Campos 2016-06-09 05:18:12 PDT
Created attachment 280912 [details]
Comment 2 WebKit Commit Bot 2016-06-09 05:19:01 PDT
Attachment 280912 [details] did not pass style-queue:

ERROR: Source/WebKit2/Shared/CoordinatedGraphics/threadedcompositor/CompositingRunLoop.h:49:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/Shared/CoordinatedGraphics/threadedcompositor/CompositingRunLoop.cpp:44:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 2 in 4 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Carlos Garcia Campos 2016-06-10 05:51:17 PDT
Committed r201922: <http://trac.webkit.org/changeset/201922>