Bug 158551 - Clean up WebSocket code
Summary: Clean up WebSocket code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-06-08 17:45 PDT by Alex Christensen
Modified: 2016-06-09 13:09 PDT (History)
1 user (show)

See Also:

Attachments
Patch (42.10 KB, patch)
2016-06-08 17:46 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (42.28 KB, patch)
2016-06-08 20:24 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews116 for mac-yosemite (1.20 MB, application/zip)
2016-06-08 21:41 PDT, Build Bot 		no flags Details
Patch (47.97 KB, patch)
2016-06-08 23:54 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (48.49 KB, patch)
2016-06-09 11:06 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (70.26 KB, patch)
2016-06-09 13:08 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2016-06-08 17:45:10 PDT 
Clean up WebSocket code
Comment 1 Alex Christensen 2016-06-08 17:46:57 PDT 
Created attachment 280859 [details]
Patch
Comment 2 Alex Christensen 2016-06-08 20:24:53 PDT 
Created attachment 280876 [details]
Patch
Comment 3 Build Bot 2016-06-08 21:41:19 PDT 
Comment on attachment 280876 [details]
Patch

Attachment 280876 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/1470285

New failing tests:
editing/selection/selection-in-iframe-removed-crash.html
Comment 4 Build Bot 2016-06-08 21:41:21 PDT 
Created attachment 280881 [details]
Archive of layout-test-results from ews116 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 5 Alex Christensen 2016-06-08 23:54:30 PDT 
Created attachment 280887 [details]
Patch
Comment 6 Darin Adler 2016-06-09 10:06:44 PDT 
Comment on attachment 280887 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=280887&action=review

> Source/WebCore/Modules/websockets/WebSocketChannel.h:199
> +    unsigned long m_unhandledBufferedAmount { 0 };

There is no reason to use "unsigned long" for this instead of "unsigned". This seems to be the typical confusion where when IDL says "long" it means "int", but sometimes people just use long in the C++ code. That’s OK except that then we have a mix of the types "int" and "long", and there is no distinction needed between the two.

For the same reason, the bufferedAmount function should return unsigned, not unsigned long.

> Source/WebCore/Modules/websockets/WebSocketChannel.h:201
> +    unsigned long m_identifier { 0 }; // m_identifier == 0 means that we could not obtain a valid identifier.

Ditto.
Comment 7 Alex Christensen 2016-06-09 11:06:36 PDT 
Created attachment 280930 [details]
Patch
Comment 8 WebKit Commit Bot 2016-06-09 11:31:55 PDT 
Comment on attachment 280930 [details]
Patch

Rejecting attachment 280930 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'build', '--no-clean', '--no-update', '--build-style=release', '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
ia -c /Volumes/Data/EWS/WebKit/WebKitBuild/Release/DerivedSources/WebCore/JSFetchRequest.cpp -o /Volumes/Data/EWS/WebKit/WebKitBuild/WebCore.build/Release/WebCore.build/Objects-normal/x86_64/JSFetchRequest.o

** BUILD FAILED **


The following build commands failed:
	CompileC /Volumes/Data/EWS/WebKit/WebKitBuild/WebCore.build/Release/WebCore.build/Objects-normal/x86_64/JSDOMWindowCustom.o bindings/js/JSDOMWindowCustom.cpp normal x86_64 c++ com.apple.compilers.llvm.clang.1_0.compiler
(1 failure)

Full output: http://webkit-queues.webkit.org/results/1473458
Comment 9 Alex Christensen 2016-06-09 13:08:43 PDT 
Created attachment 280938 [details]
Patch
Comment 10 Alex Christensen 2016-06-09 13:09:35 PDT 
http://trac.webkit.org/changeset/201880