Bug 158544 – DedicatedWorkerGlobalScope prototype chain is incorrect

• Status: RESOLVED
• Resolution: FIXED
• Component: Bindings

[Chris Dumez]

WorkerGlobalScope.prototype is [object DedicatedWorkerGlobalScopePrototype] but should be [object WorkerGlobalScopePrototype]. This is causing failures on:
http://w3c-test.org/workers/interfaces.worker

[Chris Dumez]

Seems related to this in the bindings generator:
   if (IsDOMGlobalObject($interface)) {
        push(@$outputArray, "    putDirect(vm, vm.propertyNames->prototype, globalObject.getPrototypeDirect(), DontDelete | ReadOnly | DontEnum);\n");

IsDOMGlobalObject() returns true for both WorkerGlobalScope and DedicatedWorkerGlobalScope.

[Chris Dumez]

Created attachment 280856 [details]
WIP Patch

[Chris Dumez]

Expected:
DedicatedWorkerGlobalScope.prototype.toString() === "[object DedicatedWorkerGlobalScopePrototype]": true
Object.getPrototypeOf(DedicatedWorkerGlobalScope.prototype) === WorkerGlobalScope.prototype: true
WorkerGlobalScope.prototype.toString() === "[object WorkerGlobalScopePrototype]": true
Object.getPrototypeOf(WorkerGlobalScope.prototype) === EventTarget.prototype: true

But got:
DedicatedWorkerGlobalScope.prototype.toString() === "[object DedicatedWorkerGlobalScopePrototype]": true
Object.getPrototypeOf(DedicatedWorkerGlobalScope.prototype) === WorkerGlobalScope.prototype: false
WorkerGlobalScope.prototype.toString() === "[object WorkerGlobalScopePrototype]": false
Object.getPrototypeOf(WorkerGlobalScope.prototype) === EventTarget.prototype: false

[Chris Dumez]

Created attachment 280879 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 280879 [details]
Patch

Clearing flags on attachment: 280879

Committed r201852: <http://trac.webkit.org/changeset/201852>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.