Bug 158543 – JSObject::reifyAllStaticProperties cleanup

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Gavin Barraclough]

- JSObject & Structure contain fields labeled 'staticFunctionsReified', however reification now affects all properties, not just functions. Rename to 'staticPropertiesReified'.
- reifyAllStaticProperties relies on a 'hasStaticProperties' method on ClassInfo that walks the ClassInfo inheritance chain looking for static property tables. We can now more efficiently get this information from TypeInfo.
- reifyAllStaticProperties triggers a 'toUncacheableDictionaryTransition'; this is overzealous, cacheable dictionary is sufficient - this is what we do in the case of DOM prototype property reification (see 'reifyStaticProperties' in Lookup.h). (Changing this with an eye on switching DOM prototype property reification to use JSObject:: reifyAllStaticProperties, rather than having its own special purpose code path.)

[Gavin Barraclough]

Created attachment 280842 [details]
Fix

[Mark Lam]

Comment on attachment 280842 [details]
Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=280842&action=review

r=me

> Source/JavaScriptCore/ChangeLog:9
> +        affects all properties, not just functions. Rename to 'staticPropertiesReified'.

Missing space?  Or is this a tab?

[Gavin Barraclough]

Committed revision 201853.

[Chris Dumez]

Only 1 data point so it could be noise but it looks like this may be a ~4% regression on Dromaeo DOM Core (especially the DOM Modification and DOM query subtests) on MacBookPro.

[Chris Dumez]

(In reply to comment #4)
> Only 1 data point so it could be noise but it looks like this may be a ~4%
> regression on Dromaeo DOM Core (especially the DOM Modification and DOM
> query subtests) on MacBookPro.

Looks like this was noise, the next data point looks much better.