Bug 158541 - Web Inspector: an error is encountered when trying to delete nodes that have children
Summary: Web Inspector: an error is encountered when trying to delete nodes that have ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Brian Burg
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-06-08 14:19 PDT by Brian Burg
Modified: 2016-06-08 16:15 PDT (History)
8 users (show)

See Also:


Attachments
The bad code probably responsible (117.48 KB, image/png)
2016-06-08 14:19 PDT, Brian Burg
no flags Details
Proposed Fix (1.96 KB, patch)
2016-06-08 14:30 PDT, Brian Burg
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Burg 2016-06-08 14:19:26 PDT
Created attachment 280836 [details]
The bad code probably responsible

It looks like we mistakenly try to index into a number, as in the screenshot, and we end up trying to create a DOMTreeElement with a null DOMNode. This eventually throws an exception which is dropped on the floor by DOMTreeManager._wrapClientCallback.
Comment 1 Radar WebKit Bug Importer 2016-06-08 14:24:44 PDT
<rdar://problem/26705901>
Comment 2 Brian Burg 2016-06-08 14:30:17 PDT
Created attachment 280839 [details]
Proposed Fix
Comment 3 WebKit Commit Bot 2016-06-08 16:15:42 PDT
Comment on attachment 280839 [details]
Proposed Fix

Clearing flags on attachment: 280839

Committed r201843: <http://trac.webkit.org/changeset/201843>
Comment 4 WebKit Commit Bot 2016-06-08 16:15:46 PDT
All reviewed patches have been landed.  Closing bug.