Bug 158526 - Increase disk cache capacity when there is lots of free space
Summary: Increase disk cache capacity when there is lots of free space
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-06-08 07:40 PDT by Antti Koivisto
Modified: 2016-06-09 01:40 PDT (History)
4 users (show)

See Also:

Attachments
patch (3.00 KB, patch)
2016-06-08 07:55 PDT, Antti Koivisto 		cdumez: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2016-06-08 07:40:25 PDT 
Our maximum disk cache capacity has been 175MB for very long time. Meanwhile the average resource size has grown massively. This is enough for cacheable resources of a few dozen sites at most. By using bigger caches when there is room for it can save battery and speed up page loading.
Comment 1 Antti Koivisto 2016-06-08 07:55:43 PDT 
Created attachment 280804 [details]
patch
Comment 2 Chris Dumez 2016-06-08 08:46:57 PDT 
Comment on attachment 280804 [details]
patch

R=me
Comment 3 Radar WebKit Bug Importer 2016-06-08 12:32:58 PDT 
<rdar://problem/26703263>
Comment 4 Alexey Proskuryakov 2016-06-08 13:47:35 PDT 
Comment on attachment 280804 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=280804&action=review

> Source/WebKit2/ChangeLog:15
> +        >=16GB free: 175MB -> 500MB
> +        8-16GB free: 150MB -> 250MB

Perhaps the heuristic should take into account the percentage of free space, not just the amount.

At some point, it was recommended that no more than 75% of SSD should be used (http://www.anandtech.com/show/6489/playing-with-op). I don't have newer references, but I believe that consumer grade SSDs still work the same way.
Comment 5 Antti Koivisto 2016-06-09 01:40:45 PDT 
https://trac.webkit.org/r201857