Bug 158524 - [Win] Shadow DOM tests are failing.
Summary: [Win] Shadow DOM tests are failing.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-06-08 06:47 PDT by Per Arne Vollan
Modified: 2016-06-08 11:50 PDT (History)
2 users (show)

See Also:


Attachments
Patch (8.23 KB, patch)
2016-06-08 07:06 PDT, Per Arne Vollan
bfulgham: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2016-06-08 06:47:19 PDT
This feature has not been enabled on Windows.
Comment 1 Per Arne Vollan 2016-06-08 07:06:49 PDT
Created attachment 280803 [details]
Patch
Comment 2 Brent Fulgham 2016-06-08 08:26:17 PDT
Comment on attachment 280803 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=280803&action=review

Looks good! Thanks for getting this working! :-)

> LayoutTests/platform/win/TestExpectations:3361
> +webkit.org/b/148695 fast/shadow-dom [ Pass ]

Why is this necessary if they are all passes? Can't this line just be removed? Or will the tests not run (because a parent 'TestExpectations' file has them turned off?
Comment 3 Per Arne Vollan 2016-06-08 09:41:47 PDT
(In reply to comment #2)
> Comment on attachment 280803 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=280803&action=review
> 
> Looks good! Thanks for getting this working! :-)
> 
> > LayoutTests/platform/win/TestExpectations:3361
> > +webkit.org/b/148695 fast/shadow-dom [ Pass ]
> 
> Why is this necessary if they are all passes? Can't this line just be
> removed? Or will the tests not run (because a parent 'TestExpectations' file
> has them turned off?

Yes, this will override the expectations from the top level 'TextExpectations' file. It is copied from the Mac test expectations.

Thanks for reviewing!
Comment 4 Per Arne Vollan 2016-06-08 11:50:35 PDT
Committed r201817: <http://trac.webkit.org/changeset/201817>