Bug 158515 - [EFL] Build fix related with SharedBuffer::createFromReadingFile in SharedBufferPosix.cpp
Summary: [EFL] Build fix related with SharedBuffer::createFromReadingFile in SharedBuf...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-06-07 21:18 PDT by Joonghun Park
Modified: 2016-06-07 22:02 PDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Joonghun Park 2016-06-07 21:18:07 PDT
This patch fixes the build error shown as below.

../../Source/WebCore/platform/posix/SharedBufferPOSIX.cpp: In static member function ‘static WTF::RefPtr<WebCore::SharedBuffer> WebCore::SharedBuffer::createFromReadingFile(const WTF::String&)’:
../../Source/WebCore/platform/posix/SharedBufferPOSIX.cpp:69:42: error: operands to ?: have different types ‘WTF::Ref<WebCore::SharedBuffer>’ and ‘int’
     return totalBytesRead == bytesToRead ? SharedBuffer::adoptVector(buffer) : 0;
Comment 1 Joonghun Park 2016-06-07 21:26:24 PDT
Committed r201790: <http://trac.webkit.org/changeset/201790>
Comment 2 Gyuyoung Kim 2016-06-07 21:57:30 PDT
(In reply to comment #1)
> Committed r201790: <http://trac.webkit.org/changeset/201790>

Personally I prefer to fix this issue as https://bugs.webkit.org/attachment.cgi?id=280763&action=review
Comment 3 Joonghun Park 2016-06-07 22:02:11 PDT
(In reply to comment #2)
> (In reply to comment #1)
> > Committed r201790: <http://trac.webkit.org/changeset/201790>
> 
> Personally I prefer to fix this issue as
> https://bugs.webkit.org/attachment.cgi?id=280763&action=review

I realized that I missed to change 0s to nullptr when I saw the https://bugs.webkit.org/attachment.cgi?id=280763. That would be more proper one.