RESOLVED FIXED158515
[EFL] Build fix related with SharedBuffer::createFromReadingFile in SharedBufferPosix.cpp 
https://bugs.webkit.org/show_bug.cgi?id=158515
Summary [EFL] Build fix related with SharedBuffer::createFromReadingFile in SharedBuf...
Joonghun Park
Reported 2016-06-07 21:18:07 PDT
This patch fixes the build error shown as below. ../../Source/WebCore/platform/posix/SharedBufferPOSIX.cpp: In static member function ‘static WTF::RefPtr<WebCore::SharedBuffer> WebCore::SharedBuffer::createFromReadingFile(const WTF::String&)’: ../../Source/WebCore/platform/posix/SharedBufferPOSIX.cpp:69:42: error: operands to ?: have different types ‘WTF::Ref<WebCore::SharedBuffer>’ and ‘int’ return totalBytesRead == bytesToRead ? SharedBuffer::adoptVector(buffer) : 0;
Attachments
Add attachment proposed patch, testcase, etc.
Joonghun Park
Comment 1 2016-06-07 21:26:24 PDT
Committed r201790: <http://trac.webkit.org/changeset/201790>
Gyuyoung Kim
Comment 2 2016-06-07 21:57:30 PDT
(In reply to comment #1) > Committed r201790: <http://trac.webkit.org/changeset/201790> Personally I prefer to fix this issue as https://bugs.webkit.org/attachment.cgi?id=280763&action=review
Joonghun Park
Comment 3 2016-06-07 22:02:11 PDT
(In reply to comment #2) > (In reply to comment #1) > > Committed r201790: <http://trac.webkit.org/changeset/201790> > > Personally I prefer to fix this issue as > https://bugs.webkit.org/attachment.cgi?id=280763&action=review I realized that I missed to change 0s to nullptr when I saw the https://bugs.webkit.org/attachment.cgi?id=280763. That would be more proper one.
Note You need to log in before you can comment on or make changes to this bug.