Bug 158510 - Don't try to cleanup non-existing ios Simulators
Summary: Don't try to cleanup non-existing ios Simulators
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-06-07 18:47 PDT by Aakash Jain
Modified: 2016-06-08 11:01 PDT (History)
5 users (show)

See Also:

Attachments
Proposed patch (1.25 KB, patch)
2016-06-07 19:01 PDT, Aakash Jain 		no flags Details | Formatted Diff | Diff
Proposed patch (1.24 KB, patch)
2016-06-07 19:10 PDT, Aakash Jain 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2016-06-07 18:47:54 PDT 
When for some reason run-webkit-tests fails before creating the simulators, the cleanup still tries to cleanup the simulators. The “lsregister” command fails with the error message: “error -10814 unregistering /tmp/WebKitTestingSimulators/Simulator0.app”

This just creates unnecessary logs and failed attempts. We should not try to cleanup non-existing simulators.
Comment 1 Aakash Jain 2016-06-07 19:01:59 PDT 
Created attachment 280760 [details]
Proposed patch
Comment 2 Aakash Jain 2016-06-07 19:10:24 PDT 
Created attachment 280761 [details]
Proposed patch
Comment 3 WebKit Commit Bot 2016-06-08 11:01:39 PDT 
Comment on attachment 280761 [details]
Proposed patch

Clearing flags on attachment: 280761

Committed r201812: <http://trac.webkit.org/changeset/201812>
Comment 4 WebKit Commit Bot 2016-06-08 11:01:43 PDT 
All reviewed patches have been landed.  Closing bug.