RESOLVED FIXED 158502
Uncaught Exception in TimelineDataGrid._updatePopoverForSelectedNode() 
https://bugs.webkit.org/show_bug.cgi?id=158502
Summary Uncaught Exception in TimelineDataGrid._updatePopoverForSelectedNode()
Blaze Burg
Reported 2016-06-07 17:17:52 PDT
------- Auto-generated details: Inspected URL: file:///Users/bburg/repos/webkit/OpenSource/WebKitBuild/Release/WebInspectorUI.framework/Resources/Main.html Loading completed: true Frontend User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12) AppleWebKit/602.1.36+ (KHTML, like Gecko) Uncaught exceptions: - ReferenceError: Cannot access uninitialized variable. (at TimelineDataGrid.js:492:23) ------- * STEPS TO REPRODUCE 1. Create a timeline recording with layout data on it 2. Go to Layout & Rendering timeline 3. Sort by duration by clicking on the heading -> Exception! It looks like the code in TimelineDataGrid._updatePopoverForSelectedNode() is pretty messed up. It uses `targetFrame` in a conditional before declaring it a dozen lines later. The conditional itself doesn't look correct either, so this code should be audited when this is looked at.
Attachments
Proposed Fix (1.88 KB, patch)
2016-06-08 15:28 PDT, Blaze Burg 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2016-06-07 17:18:20 PDT
<rdar://problem/26687038>
Radar WebKit Bug Importer
Comment 2 2016-06-07 17:18:56 PDT
<rdar://problem/26687044>
Blaze Burg
Comment 3 2016-06-08 15:28:20 PDT
Created attachment 280847 [details] Proposed Fix
Joseph Pecoraro
Comment 4 2016-06-08 15:31:23 PDT
Comment on attachment 280847 [details] Proposed Fix r=me
WebKit Commit Bot
Comment 5 2016-06-08 16:01:10 PDT
Comment on attachment 280847 [details] Proposed Fix Clearing flags on attachment: 280847 Committed r201839: <http://trac.webkit.org/changeset/201839>
WebKit Commit Bot
Comment 6 2016-06-08 16:01:14 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.