Bug 158502 - Uncaught Exception in TimelineDataGrid._updatePopoverForSelectedNode()
Summary: Uncaught Exception in TimelineDataGrid._updatePopoverForSelectedNode()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: BJ Burg
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-06-07 17:17 PDT by BJ Burg
Modified: 2016-06-08 16:01 PDT (History)
8 users (show)

See Also:

Attachments
Proposed Fix (1.88 KB, patch)
2016-06-08 15:28 PDT, BJ Burg 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description BJ Burg 2016-06-07 17:17:52 PDT 
-------
Auto-generated details:

Inspected URL:        file:///Users/bburg/repos/webkit/OpenSource/WebKitBuild/Release/WebInspectorUI.framework/Resources/Main.html
Loading completed:    true
Frontend User Agent:  Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12) AppleWebKit/602.1.36+ (KHTML, like Gecko)
Uncaught exceptions:
 - ReferenceError: Cannot access uninitialized variable. (at TimelineDataGrid.js:492:23)
-------

* STEPS TO REPRODUCE
1. Create a timeline recording with layout data on it
2. Go to Layout & Rendering timeline
3. Sort by duration by clicking on the heading

-> Exception!

It looks like the code in TimelineDataGrid._updatePopoverForSelectedNode() is pretty messed up. It uses `targetFrame` in a conditional before declaring it a dozen lines later. The conditional itself doesn't look correct either, so this code should be audited when this is looked at.
Comment 1 Radar WebKit Bug Importer 2016-06-07 17:18:20 PDT 
<rdar://problem/26687038>
Comment 2 Radar WebKit Bug Importer 2016-06-07 17:18:56 PDT 
<rdar://problem/26687044>
Comment 3 BJ Burg 2016-06-08 15:28:20 PDT 
Created attachment 280847 [details]
Proposed Fix
Comment 4 Joseph Pecoraro 2016-06-08 15:31:23 PDT 
Comment on attachment 280847 [details]
Proposed Fix

r=me
Comment 5 WebKit Commit Bot 2016-06-08 16:01:10 PDT 
Comment on attachment 280847 [details]
Proposed Fix

Clearing flags on attachment: 280847

Committed r201839: <http://trac.webkit.org/changeset/201839>
Comment 6 WebKit Commit Bot 2016-06-08 16:01:14 PDT 
All reviewed patches have been landed.  Closing bug.