Bug 158493 - Add result validation to JSAir
Summary: Add result validation to JSAir
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks: 158492
  Show dependency treegraph
 
Reported: 2016-06-07 13:59 PDT by Filip Pizlo
Modified: 2016-06-09 10:46 PDT (History)
14 users (show)

See Also:


Attachments
almost done (320.81 KB, patch)
2016-06-07 22:02 PDT, Filip Pizlo
no flags Details | Formatted Diff | Diff
the patch (616.32 KB, patch)
2016-06-07 23:59 PDT, Filip Pizlo
no flags Details | Formatted Diff | Diff
smaller patch (548.17 KB, patch)
2016-06-08 00:01 PDT, Filip Pizlo
no flags Details | Formatted Diff | Diff
even smaller patch (345.37 KB, patch)
2016-06-08 00:03 PDT, Filip Pizlo
no flags Details | Formatted Diff | Diff
even smaller patch (218.46 KB, patch)
2016-06-08 00:18 PDT, Filip Pizlo
no flags Details | Formatted Diff | Diff
so small patch (111.34 KB, patch)
2016-06-08 00:19 PDT, Filip Pizlo
sbarati: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2016-06-07 13:59:42 PDT
Patch forthcoming.
Comment 1 Filip Pizlo 2016-06-07 22:02:51 PDT
Created attachment 280767 [details]
almost done
Comment 2 Filip Pizlo 2016-06-07 22:03:05 PDT
I found some excellent bugs while doing this.
Comment 3 Filip Pizlo 2016-06-07 23:59:35 PDT
Created attachment 280780 [details]
the patch
Comment 4 Filip Pizlo 2016-06-08 00:01:26 PDT
Created attachment 280781 [details]
smaller patch
Comment 5 Filip Pizlo 2016-06-08 00:03:10 PDT
Created attachment 280782 [details]
even smaller patch
Comment 6 Filip Pizlo 2016-06-08 00:18:34 PDT
Created attachment 280785 [details]
even smaller patch
Comment 7 Filip Pizlo 2016-06-08 00:19:44 PDT
Created attachment 280786 [details]
so small patch
Comment 8 Saam Barati 2016-06-08 00:46:00 PDT
Comment on attachment 280786 [details]
so small patch

View in context: https://bugs.webkit.org/attachment.cgi?id=280786&action=review

> PerformanceTests/JSAir/benchmark.js:64
> +                throw new Error("Wrong early hash for " + payload.generate.name +": " + hash);

s/early/late
Comment 9 Filip Pizlo 2016-06-08 10:20:49 PDT
Landed in http://trac.webkit.org/changeset/201807