RESOLVED FIXED 158491
Web Inspector: reduce timer churn when processing many DOM.attributeModified messages
https://bugs.webkit.org/show_bug.cgi?id=158491
Summary Web Inspector: reduce timer churn when processing many DOM.attributeModified ...
Blaze Burg
Reported 2016-06-07 13:36:23 PDT
This patch fixes two issues at play in 142466 and 156250. We currently use the Object.debounce/Object.soon proxy to try to coalesce calls to DOMTreeUpdater._attributesModified. Unfortunately, this doesn't coalesce very many calls because .soon is equivalent to using setTimeout(0). So we end up setting and clearing a timer for every attribute modification, and only coalesce calls until the timer fires. This means we also update the DOMTreeOutline multiple times per frame because this work is not done on a requestAnimationFrame, and the timer could fire many times in a frame's time slice.
Attachments
Proposed Fix (7.15 KB, patch)
2016-06-07 13:57 PDT, Blaze Burg
timothy: review+
bburg: commit-queue-
Blaze Burg
Comment 1 2016-06-07 13:36:37 PDT
Blaze Burg
Comment 2 2016-06-07 13:57:22 PDT
Created attachment 280736 [details] Proposed Fix
Blaze Burg
Comment 3 2016-06-07 17:30:41 PDT
Note You need to log in before you can comment on or make changes to this bug.