Bug 158488 - calculatedDisplayName() and friends actually need a VM& and not a ExecState/CallFrame.
Summary: calculatedDisplayName() and friends actually need a VM& and not a ExecState/C...
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
Depends on:
Reported: 2016-06-07 11:57 PDT by Mark Lam
Modified: 2016-06-07 12:54 PDT (History)
4 users (show)

See Also:

proposed patch. (16.20 KB, patch)
2016-06-07 12:06 PDT, Mark Lam
ggaren: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2016-06-07 11:57:41 PDT
calculatedDisplayName() (and some of its friends) actually just need a VM&.  Their work has nothing to do with an ExecState at all.  This patch will make that clear by changing these functions to take a VM& arg instead of an ExecState* or CallFrame*.
Comment 1 Mark Lam 2016-06-07 12:06:15 PDT
Created attachment 280729 [details]
proposed patch.
Comment 2 Geoffrey Garen 2016-06-07 12:07:55 PDT
Comment on attachment 280729 [details]
proposed patch.

Comment 3 Mark Lam 2016-06-07 12:52:41 PDT
Thanks for the review.  Landed in r201766: <http://trac.webkit.org/r201766>.

Unfortunately, I didn't see the complaining EWS bots till now.  I'll look into it.
Comment 4 Mark Lam 2016-06-07 12:53:54 PDT
EWS bots says that they are unable to build without my patch.  So, not my issue.  And I'm good to go.