RESOLVED FIXED Bug 158488
calculatedDisplayName() and friends actually need a VM& and not a ExecState/CallFrame. 
https://bugs.webkit.org/show_bug.cgi?id=158488
Summary calculatedDisplayName() and friends actually need a VM& and not a ExecState/C...
Mark Lam
Reported 2016-06-07 11:57:41 PDT
calculatedDisplayName() (and some of its friends) actually just need a VM&. Their work has nothing to do with an ExecState at all. This patch will make that clear by changing these functions to take a VM& arg instead of an ExecState* or CallFrame*.
Attachments
proposed patch. (16.20 KB, patch)
2016-06-07 12:06 PDT, Mark Lam 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2016-06-07 12:06:15 PDT
Created attachment 280729 [details] proposed patch.
Geoffrey Garen
Comment 2 2016-06-07 12:07:55 PDT
Comment on attachment 280729 [details] proposed patch. r=me
Mark Lam
Comment 3 2016-06-07 12:52:41 PDT
Thanks for the review. Landed in r201766: <http://trac.webkit.org/r201766>. Unfortunately, I didn't see the complaining EWS bots till now. I'll look into it.
Mark Lam
Comment 4 2016-06-07 12:53:54 PDT
EWS bots says that they are unable to build without my patch. So, not my issue. And I'm good to go.
Note You need to log in before you can comment on or make changes to this bug.