We need to expose whether an element is a dialog element to higher level code to determine VoiceOver behavior on iOS
<rdar://problem/26678218>
Created attachment 280726 [details] Patch
Layout test? Nit: Re-read your ChangeLog statement (in particular the commas and position of "so" cannot all be what you want)
Created attachment 280732 [details] Patch
(In reply to comment #3) > Layout test? > > Nit: Re-read your ChangeLog statement (in particular the commas and position > of "so" cannot all be what you want) Updated
(In reply to comment #5) > (In reply to comment #3) > > Layout test? > > > > Nit: Re-read your ChangeLog statement (in particular the commas and position > > of "so" cannot all be what you want) > > Updated But still no layout test?
(In reply to comment #6) > (In reply to comment #5) > > (In reply to comment #3) > > > Layout test? > > > > > > Nit: Re-read your ChangeLog statement (in particular the commas and position > > > of "so" cannot all be what you want) > > > > Updated > > But still no layout test? There's nothing to test at this level of WebCore.
Comment on attachment 280732 [details] Patch (In reply to comment #7) > There's nothing to test at this level of WebCore. With respect to VoiceOver, sure. I would have thought that the attribute being exposed here to address the VO issue would warrant a test. But ok.
(In reply to comment #8) > Comment on attachment 280732 [details] > Patch > > (In reply to comment #7) > > > There's nothing to test at this level of WebCore. > > With respect to VoiceOver, sure. I would have thought that the attribute > being exposed here to address the VO issue would warrant a test. But ok. That logic can't be tested at this level. Needs to be higher up
Comment on attachment 280732 [details] Patch Clearing flags on attachment: 280732 Committed r201774: <http://trac.webkit.org/changeset/201774>
All reviewed patches have been landed. Closing bug.