Bug 158487 - AX: iOS: Need to expose whether object is a dialog element
Summary: AX: iOS: Need to expose whether object is a dialog element
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: Other
Hardware: All All
: P2 Normal
Assignee: chris fleizach
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-06-07 11:37 PDT by chris fleizach
Modified: 2016-06-07 15:44 PDT (History)
9 users (show)

See Also:


Attachments
Patch (1.52 KB, patch)
2016-06-07 11:39 PDT, chris fleizach
no flags Details | Formatted Diff | Diff
Patch (1.55 KB, patch)
2016-06-07 12:25 PDT, chris fleizach
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description chris fleizach 2016-06-07 11:37:19 PDT
We need to expose whether an element is a dialog element to higher level code to determine VoiceOver behavior on iOS
Comment 1 chris fleizach 2016-06-07 11:37:32 PDT
<rdar://problem/26678218>
Comment 2 chris fleizach 2016-06-07 11:39:28 PDT
Created attachment 280726 [details]
Patch
Comment 3 Joanmarie Diggs (irc: joanie) 2016-06-07 11:56:04 PDT
Layout test?

Nit: Re-read your ChangeLog statement (in particular the commas and position of "so" cannot all be what you want)
Comment 4 chris fleizach 2016-06-07 12:25:57 PDT
Created attachment 280732 [details]
Patch
Comment 5 chris fleizach 2016-06-07 12:26:06 PDT
(In reply to comment #3)
> Layout test?
> 
> Nit: Re-read your ChangeLog statement (in particular the commas and position
> of "so" cannot all be what you want)

Updated
Comment 6 Joanmarie Diggs (irc: joanie) 2016-06-07 13:28:47 PDT
(In reply to comment #5)
> (In reply to comment #3)
> > Layout test?
> > 
> > Nit: Re-read your ChangeLog statement (in particular the commas and position
> > of "so" cannot all be what you want)
> 
> Updated

But still no layout test?
Comment 7 chris fleizach 2016-06-07 13:47:12 PDT
(In reply to comment #6)
> (In reply to comment #5)
> > (In reply to comment #3)
> > > Layout test?
> > > 
> > > Nit: Re-read your ChangeLog statement (in particular the commas and position
> > > of "so" cannot all be what you want)
> > 
> > Updated
> 
> But still no layout test?

There's nothing to test at this level of WebCore.
Comment 8 Joanmarie Diggs (irc: joanie) 2016-06-07 15:16:03 PDT
Comment on attachment 280732 [details]
Patch

(In reply to comment #7)

> There's nothing to test at this level of WebCore.

With respect to VoiceOver, sure. I would have thought that the attribute being exposed here to address the VO issue would warrant a test. But ok.
Comment 9 chris fleizach 2016-06-07 15:21:24 PDT
(In reply to comment #8)
> Comment on attachment 280732 [details]
> Patch
> 
> (In reply to comment #7)
> 
> > There's nothing to test at this level of WebCore.
> 
> With respect to VoiceOver, sure. I would have thought that the attribute
> being exposed here to address the VO issue would warrant a test. But ok.

That logic can't be tested at this level. Needs to be higher up
Comment 10 WebKit Commit Bot 2016-06-07 15:44:26 PDT
Comment on attachment 280732 [details]
Patch

Clearing flags on attachment: 280732

Committed r201774: <http://trac.webkit.org/changeset/201774>
Comment 11 WebKit Commit Bot 2016-06-07 15:44:30 PDT
All reviewed patches have been landed.  Closing bug.