Bug 158485 - [iOS WK1] Remove unused -_webkit_unescapedQueryValue and -_webkit_queryKeysAndValues NSString category methods
Summary: [iOS WK1] Remove unused -_webkit_unescapedQueryValue and -_webkit_queryKeysAn...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-06-07 10:51 PDT by David Kilzer (:ddkilzer)
Modified: 2016-06-07 11:54 PDT (History)
6 users (show)

See Also:

Attachments
Patch v1 (4.91 KB, patch)
2016-06-07 10:54 PDT, David Kilzer (:ddkilzer) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2016-06-07 10:51:06 PDT 
The -_webkit_unescapedQueryValue and -_webkit_queryKeysAndValues NSString category methods are no longer used in WebKit, and the implementation of -_webkit_queryKeysAndValues is buggy since it can't handle multiple values with the same key.

Instead you should create an NSURLComponents object, and call -queryItems to get the list of key-value pairs:

<https://developer.apple.com/library/ios/documentation/Foundation/Reference/NSURLComponents_class/index.html#//apple_ref/occ/instp/NSURLComponents/queryItems>
Comment 1 David Kilzer (:ddkilzer) 2016-06-07 10:51:39 PDT 
<rdar://problem/16960445>
Comment 2 David Kilzer (:ddkilzer) 2016-06-07 10:54:20 PDT 
Created attachment 280723 [details]
Patch v1
Comment 3 WebKit Commit Bot 2016-06-07 11:54:34 PDT 
Comment on attachment 280723 [details]
Patch v1

Clearing flags on attachment: 280723

Committed r201763: <http://trac.webkit.org/changeset/201763>
Comment 4 WebKit Commit Bot 2016-06-07 11:54:38 PDT 
All reviewed patches have been landed.  Closing bug.