RESOLVED FIXED 158485
[iOS WK1] Remove unused -_webkit_unescapedQueryValue and -_webkit_queryKeysAndValues NSString category methods 
https://bugs.webkit.org/show_bug.cgi?id=158485
Summary [iOS WK1] Remove unused -_webkit_unescapedQueryValue and -_webkit_queryKeysAn...
David Kilzer (:ddkilzer)
Reported 2016-06-07 10:51:06 PDT
The -_webkit_unescapedQueryValue and -_webkit_queryKeysAndValues NSString category methods are no longer used in WebKit, and the implementation of -_webkit_queryKeysAndValues is buggy since it can't handle multiple values with the same key. Instead you should create an NSURLComponents object, and call -queryItems to get the list of key-value pairs: <https://developer.apple.com/library/ios/documentation/Foundation/Reference/NSURLComponents_class/index.html#//apple_ref/occ/instp/NSURLComponents/queryItems>
Attachments
Patch v1 (4.91 KB, patch)
2016-06-07 10:54 PDT, David Kilzer (:ddkilzer) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
David Kilzer (:ddkilzer)
Comment 1 2016-06-07 10:51:39 PDT
<rdar://problem/16960445>
David Kilzer (:ddkilzer)
Comment 2 2016-06-07 10:54:20 PDT
Created attachment 280723 [details] Patch v1
WebKit Commit Bot
Comment 3 2016-06-07 11:54:34 PDT
Comment on attachment 280723 [details] Patch v1 Clearing flags on attachment: 280723 Committed r201763: <http://trac.webkit.org/changeset/201763>
WebKit Commit Bot
Comment 4 2016-06-07 11:54:38 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.