Bug 158480 - Investigate cause of flakiness in http/tests/websocket/tests/hybi/upgrade-simple-ws.html test
Summary: Investigate cause of flakiness in http/tests/websocket/tests/hybi/upgrade-sim...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords:
Depends on: 143653
Blocks:
  Show dependency treegraph
 
Reported: 2016-06-07 08:48 PDT by Brent Fulgham
Modified: 2019-05-02 16:22 PDT (History)
7 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2016-06-07 08:48:54 PDT
Investigate the cause of flakiness in the WebSocket upgrade code path:

Test: http/tests/websocket/tests/hybi/upgrade-simple-ws.html

The test is a flaky failure on El Capitan and iOS simulator. It is failing and crashing on Windows.

Recent failure:
<https://build.webkit.org/builders/Apple%20El%20Capitan%20Debug%20WK1%20(Tests)/builds/5721>

Flakiness dashboard:
<https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Fwebsocket%2Ftests%2Fhybi%2Fupgrade-simple-ws.html>

--- /Volumes/Data/slave/ios-simulator-9-release-tests-wk2/build/layout-test-results/http/tests/websocket/tests/hybi/upgrade-simple-ws-expected.txt
+++ /Volumes/Data/slave/ios-simulator-9-release-tests-wk2/build/layout-test-results/http/tests/websocket/tests/hybi/upgrade-simple-ws-actual.txt
@@ -4,8 +4,4 @@
 
 Created a socket to 'wss://127.0.0.1:9323/websocket/tests/hybi/simple'; readyState 0.
 The 'ws' protocol should be upgraded to 'wss'. If this happens, we will connect properly and the test will succeed.
-Connected; readyState 1
-Resolved URL: wss://127.0.0.1:9323/websocket/tests/hybi/simple
-Received: 'Hello from Simple WSH.'; readyState 1
-Closed; readyState 3.
Comment 1 Brent Fulgham 2016-06-07 10:32:03 PDT
About 1 in 1000 times I can get the test to time out, but I'm not seeing other failures. Since this test relies on an external Python server to do its work, we might be running into some flakiness with that dependency.
Comment 2 Alexey Proskuryakov 2016-06-07 20:15:43 PDT
Will it reproduce when forced to run many copies of itself in parallel?