Bug 158478 – [WebVTT] change "middle" to "center" for consistency with CSS

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Eric Carlson]

The WebVTT spec is changing align from 'middle' to 'center' to match CSS [1]. According to Simon's analysis this change should not cause serious compatibility problems [2].


[1] https://github.com/w3c/webvtt/pull/244
[2] https://github.com/w3c/webvtt/issues/301#issuecomment-224235961

[Radar WebKit Bug Importer]

<rdar://problem/26672692>

[Simon Pieters (:zcorpan)]

This is now fixed in Gecko (don't know bug #) and Chromium

https://bugs.chromium.org/p/chromium/issues/detail?id=663797

web-platform-tests expect "center".

[Simon Pieters (:zcorpan)]

e.g. http://w3c-test.org/webvtt/api/VTTCue/align.html

[Per Arne Vollan]

Created attachment 349961 [details]
Patch

[EWS Watchlist]

Comment on attachment 349961 [details]
Patch

Attachment 349961 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/9249797

New failing tests:
media/track/track-webvtt-tc021-valign.html

[EWS Watchlist]

Created attachment 349976 [details]
Archive of layout-test-results from ews100 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-sierra  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 349961 [details]
Patch

Attachment 349961 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/9249799

New failing tests:
media/track/track-webvtt-tc021-valign.html

[EWS Watchlist]

Created attachment 349981 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6

[EWS Watchlist]

Comment on attachment 349961 [details]
Patch

Attachment 349961 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/9250443

New failing tests:
media/track/track-webvtt-tc021-valign.html

[EWS Watchlist]

Created attachment 349983 [details]
Archive of layout-test-results from ews107 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 349961 [details]
Patch

Attachment 349961 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/9250216

New failing tests:
media/track/track-webvtt-tc021-valign.html

[EWS Watchlist]

Created attachment 349984 [details]
Archive of layout-test-results from ews113 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-sierra  Platform: Mac OS X 10.12.6

[Eric Carlson]

Comment on attachment 349961 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=349961&action=review

> LayoutTests/media/track/track-webvtt-tc021-valign.html:36
> -                            values : ["middle", "middle", "start"],
> +                            values : ["center", "center", "center"],

Nit: did you mean to change "start" to "center"?

[Per Arne Vollan]

Created attachment 350019 [details]
Patch

[Eric Carlson]

Comment on attachment 350019 [details]
Patch

r=me once the bots are happy.

[Per Arne Vollan]

Comment on attachment 350019 [details]
Patch

Thanks for reviewing!

[WebKit Commit Bot]

Comment on attachment 350019 [details]
Patch

Clearing flags on attachment: 350019

Committed r236143: <https://trac.webkit.org/changeset/236143>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.