Bug 158475 - [GTK] Enable IndexedDB in workers
Summary: [GTK] Enable IndexedDB in workers
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Keywords: Gtk, LayoutTestFailure
Depends on:
Reported: 2016-06-07 04:30 PDT by Carlos Garcia Campos
Modified: 2016-06-07 23:52 PDT (History)
1 user (show)

See Also:

Patch (1.37 KB, patch)
2016-06-07 04:32 PDT, Carlos Garcia Campos
tonikitoo: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2016-06-07 04:30:25 PDT
This is working on and many tests are failing only because we don't enable it.
Comment 1 Carlos Garcia Campos 2016-06-07 04:32:12 PDT
Created attachment 280693 [details]

I meant it's working *now*
Comment 2 Michael Catanzaro 2016-06-07 06:59:33 PDT
Comment on attachment 280693 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=280693&action=review

> Source/cmake/OptionsGTK.cmake:164

I'll just note that this setting should not have been listed here previously, as ENABLE_INDEXED_DATABASE_IN_WORKERS is OFF by default, and this is a list of settings overrides.

I'm suspicious that it really makes sense for IndexedDB to be OFF by default for most ports, though, since most ports surely want it. In such cases, it'd be better to fix the default and disable it just for those ports that can't support it yet.

I'm also suspicious as to why ENABLE_INDEXED_DATABASE_IN_WORKERS is a separate option... why would any port want IndexedDB, but not in workers?
Comment 3 Carlos Garcia Campos 2016-06-07 23:52:53 PDT
Committed r201797: <http://trac.webkit.org/changeset/201797>