Bug 158475 – [GTK] Enable IndexedDB in workers

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Carlos Garcia Campos]

This is working on and many tests are failing only because we don't enable it.

[Carlos Garcia Campos]

Created attachment 280693 [details]
Patch

I meant it's working *now*

[Michael Catanzaro]

Comment on attachment 280693 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=280693&action=review

> Source/cmake/OptionsGTK.cmake:164
> +WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_INDEXED_DATABASE_IN_WORKERS PRIVATE ON)

I'll just note that this setting should not have been listed here previously, as ENABLE_INDEXED_DATABASE_IN_WORKERS is OFF by default, and this is a list of settings overrides.

I'm suspicious that it really makes sense for IndexedDB to be OFF by default for most ports, though, since most ports surely want it. In such cases, it'd be better to fix the default and disable it just for those ports that can't support it yet.

I'm also suspicious as to why ENABLE_INDEXED_DATABASE_IN_WORKERS is a separate option... why would any port want IndexedDB, but not in workers?

[Carlos Garcia Campos]

Committed r201797: <http://trac.webkit.org/changeset/201797>