Bug 158470 – [GTK] Fail to build on FreeBSD because locale.h is not included

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Ting-Wei Lan]

Here are the error messages:

/home/lantw44/webkit/source/WebKit/Source/JavaScriptCore/jsc.cpp:1955:20: error: use of undeclared identifier 'LC_ALL'
    if (!setlocale(LC_ALL, ""))
                   ^
1 error generated.
Source/JavaScriptCore/shell/CMakeFiles/jsc.dir/build.make:62: recipe for target 'Source/JavaScriptCore/shell/CMakeFiles/jsc.dir/__/jsc.cpp.o' failed

[Ting-Wei Lan]

Created attachment 280685 [details]
Patch

[Darin Adler]

Comment on attachment 280685 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=280685&action=review

> Source/JavaScriptCore/jsc.cpp:114
> +#if PLATFORM(GTK)
> +#include <locale.h>
> +#endif

No reason to put that inside an #if. Should just include this header unconditionally.

[Darin Adler]

Comment on attachment 280685 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=280685&action=review

>> Source/JavaScriptCore/jsc.cpp:114
>> +#endif
> 
> No reason to put that inside an #if. Should just include this header unconditionally.

Sorry, I don’t mean "no reason", but still, lets include it unconditionally.

[Ting-Wei Lan]

(In reply to comment #3)
> >> Source/JavaScriptCore/jsc.cpp:114
> >> +#endif
> > 
> > No reason to put that inside an #if. Should just include this header unconditionally.
> 
> Sorry, I don’t mean "no reason", but still, lets include it unconditionally.

OK, I did that because setlocale and LC_ALL are only used by PLATFORM(GTK).

[Ting-Wei Lan]

Created attachment 280709 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 280709 [details]
Patch

Clearing flags on attachment: 280709

Committed r201755: <http://trac.webkit.org/changeset/201755>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.