Bug 158454 - Adopt [PDFView documentScrollView]
Summary: Adopt [PDFView documentScrollView]
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-06-06 17:42 PDT by Alex Christensen
Modified: 2016-06-07 11:59 PDT (History)
4 users (show)

See Also:


Attachments
Patch (2.00 KB, patch)
2016-06-06 17:43 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (3.56 KB, patch)
2016-06-06 22:08 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (3.36 KB, patch)
2016-06-07 09:48 PDT, Alex Christensen
thorton: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2016-06-06 17:42:28 PDT
Adopt [PDFView documentScrollView]
Comment 1 Alex Christensen 2016-06-06 17:43:42 PDT
Created attachment 280654 [details]
Patch
Comment 2 Tim Horton 2016-06-06 18:42:28 PDT
Comment on attachment 280654 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=280654&action=review

> Source/WebKit/mac/WebView/WebPDFView.h:40
> +@interface PDFView()

Space before the () (and maybe this should be in PDFViewSPI.h?)

> Source/WebKit/mac/WebView/WebPDFView.mm:1137
> +#if __MAC_OS_X_VERSION_MAX_ALLOWED < 101200

IS MAX_ALLOWED right? I would have assumed MIN_REQUIRED, but I never know.
Comment 3 Tim Horton 2016-06-06 18:42:44 PDT
Comment on attachment 280654 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=280654&action=review

> Source/WebKit/mac/WebView/WebPDFView.h:41
> +- (PDFKitPlatformScrollView*) documentScrollView;

No space after the )
Comment 4 Tim Horton 2016-06-06 18:42:58 PDT
Comment on attachment 280654 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=280654&action=review

>> Source/WebKit/mac/WebView/WebPDFView.h:41
>> +- (PDFKitPlatformScrollView*) documentScrollView;
> 
> No space after the )

Space after the star.
Comment 5 Alex Christensen 2016-06-06 21:57:14 PDT
Comment on attachment 280654 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=280654&action=review

>> Source/WebKit/mac/WebView/WebPDFView.mm:1137
>> +#if __MAC_OS_X_VERSION_MAX_ALLOWED < 101200
> 
> IS MAX_ALLOWED right? I would have assumed MIN_REQUIRED, but I never know.

Yep, MIN_REQUIRED is right
Comment 6 Alex Christensen 2016-06-06 22:08:34 PDT
Created attachment 280669 [details]
Patch
Comment 7 Tim Horton 2016-06-06 22:48:19 PDT
Comment on attachment 280669 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=280669&action=review

> Source/WebKit/mac/WebView/PDFViewSPI.h:2
> + * Copyright (C) 2016 Apple Inc.  All rights reserved.

This is not the right copyright header, I'm pretty sure we use the 2-clause license for new code.
Comment 8 Alex Christensen 2016-06-07 09:48:06 PDT
Created attachment 280714 [details]
Patch
Comment 9 Alex Christensen 2016-06-07 11:59:48 PDT
http://trac.webkit.org/changeset/201758