RESOLVED FIXED Bug 158454
Adopt [PDFView documentScrollView] 
https://bugs.webkit.org/show_bug.cgi?id=158454
Summary Adopt [PDFView documentScrollView]
Alex Christensen
Reported 2016-06-06 17:42:28 PDT
Adopt [PDFView documentScrollView]
Attachments
Patch (2.00 KB, patch)
2016-06-06 17:43 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (3.56 KB, patch)
2016-06-06 22:08 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (3.36 KB, patch)
2016-06-07 09:48 PDT, Alex Christensen 		thorton: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2016-06-06 17:43:42 PDT
Created attachment 280654 [details] Patch
Tim Horton
Comment 2 2016-06-06 18:42:28 PDT
Comment on attachment 280654 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=280654&action=review > Source/WebKit/mac/WebView/WebPDFView.h:40 > +@interface PDFView() Space before the () (and maybe this should be in PDFViewSPI.h?) > Source/WebKit/mac/WebView/WebPDFView.mm:1137 > +#if __MAC_OS_X_VERSION_MAX_ALLOWED < 101200 IS MAX_ALLOWED right? I would have assumed MIN_REQUIRED, but I never know.
Tim Horton
Comment 3 2016-06-06 18:42:44 PDT
Comment on attachment 280654 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=280654&action=review > Source/WebKit/mac/WebView/WebPDFView.h:41 > +- (PDFKitPlatformScrollView*) documentScrollView; No space after the )
Tim Horton
Comment 4 2016-06-06 18:42:58 PDT
Comment on attachment 280654 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=280654&action=review >> Source/WebKit/mac/WebView/WebPDFView.h:41 >> +- (PDFKitPlatformScrollView*) documentScrollView; > > No space after the ) Space after the star.
Alex Christensen
Comment 5 2016-06-06 21:57:14 PDT
Comment on attachment 280654 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=280654&action=review >> Source/WebKit/mac/WebView/WebPDFView.mm:1137 >> +#if __MAC_OS_X_VERSION_MAX_ALLOWED < 101200 > > IS MAX_ALLOWED right? I would have assumed MIN_REQUIRED, but I never know. Yep, MIN_REQUIRED is right
Alex Christensen
Comment 6 2016-06-06 22:08:34 PDT
Created attachment 280669 [details] Patch
Tim Horton
Comment 7 2016-06-06 22:48:19 PDT
Comment on attachment 280669 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=280669&action=review > Source/WebKit/mac/WebView/PDFViewSPI.h:2 > + * Copyright (C) 2016 Apple Inc. All rights reserved. This is not the right copyright header, I'm pretty sure we use the 2-clause license for new code.
Alex Christensen
Comment 8 2016-06-07 09:48:06 PDT
Created attachment 280714 [details] Patch
Alex Christensen
Comment 9 2016-06-07 11:59:48 PDT
http://trac.webkit.org/changeset/201758
Note You need to log in before you can comment on or make changes to this bug.