Bug 158447 – Begin separating NSURLRequest and CFURLRequest storage

• Status: NEW
• Component: New Bugs

[Alex Christensen]

Begin separating NSURLRequest and CFURLRequest storage

[Alex Christensen]

Created attachment 280644 [details]
Patch

[WebKit Commit Bot]

Attachment 280644 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Alex Christensen]

Created attachment 280646 [details]
Patch

[Alex Christensen]

Created attachment 280650 [details]
Patch

[Darin Adler]

Comment on attachment 280650 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=280650&action=review

> Source/WebCore/platform/network/cocoa/ResourceRequestCocoa.mm:57
> +    return [[[NSMutableURLRequest alloc] _initWithCFURLRequest:m_cfRequest.get()] autorelease];

Seems like this could be really inefficient if someone calls this function repeatedly. Allocating a new one every time.

> Source/WebCore/platform/network/cocoa/ResourceResponseCocoa.mm:115
> +    return [NSURLResponse _responseWithCFURLResponse:m_cfResponse.get()];

Seems like this could be really inefficient if someone calls this function repeatedly. Allocating a new one every time.

[Alex Christensen]

Comment on attachment 280650 [details]
Patch

You're right, but it's also memory inefficient to keep two copies of the same thing alive, one NSURLRespose and one CFURLResponse.
I think it may be premature to clean up this code while we still build for iOS9.  Once that's done, though, I want to clean up ResourceResponse and ResourceRequest.