Bug 158418 - [EFL] Move efl include paths to JavaScriptCore_SYSTEM_INCLUDE_DIRECTORIES
Summary: [EFL] Move efl include paths to JavaScriptCore_SYSTEM_INCLUDE_DIRECTORIES
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-06-06 05:59 PDT by Gyuyoung Kim
Modified: 2016-06-06 07:29 PDT (History)
3 users (show)

See Also:


Attachments
Patch (1.51 KB, patch)
2016-06-06 05:59 PDT, Gyuyoung Kim
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2016-06-06 05:59:03 PDT
In Source/JavaScriptCore/PlatformEfl.cmake, we don't use JavaScriptCore_SYSTEM_INCLUDE_DIRECTORIES for efl include paths. Let's use it.
Comment 1 Gyuyoung Kim 2016-06-06 05:59:56 PDT
Created attachment 280592 [details]
Patch
Comment 2 Csaba Osztrogonác 2016-06-06 06:48:14 PDT
Is JavaScriptCore_SYSTEM_INCLUDE_DIRECTORIES to avoid 
possible warnings in third party header files?
Comment 3 Gyuyoung Kim 2016-06-06 06:54:57 PDT
(In reply to comment #2)
> Is JavaScriptCore_SYSTEM_INCLUDE_DIRECTORIES to avoid 
> possible warnings in third party header files?

Yes, right. FYI - https://trac.webkit.org/changeset/185806
Comment 4 Csaba Osztrogonác 2016-06-06 07:06:35 PDT
Comment on attachment 280592 [details]
Patch

OK, r=me.
Comment 5 WebKit Commit Bot 2016-06-06 07:29:54 PDT
Comment on attachment 280592 [details]
Patch

Clearing flags on attachment: 280592

Committed r201711: <http://trac.webkit.org/changeset/201711>
Comment 6 WebKit Commit Bot 2016-06-06 07:29:58 PDT
All reviewed patches have been landed.  Closing bug.