Bug 158415 - Replace scoped flag in Event by composed flag
Summary: Replace scoped flag in Event by composed flag
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
Depends on:
Blocks: 148695
  Show dependency treegraph
 
Reported: 2016-06-06 01:19 PDT by Ryosuke Niwa
Modified: 2016-07-17 20:14 PDT (History)
9 users (show)

See Also:


Attachments
Renames the flag (56.39 KB, patch)
2016-07-07 15:26 PDT, Ryosuke Niwa
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews123 for ios-simulator-wk2 (771.46 KB, application/zip)
2016-07-07 16:30 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews102 for mac-yosemite (933.48 KB, application/zip)
2016-07-07 16:30 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews112 for mac-yosemite (1.54 MB, application/zip)
2016-07-07 16:34 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews105 for mac-yosemite-wk2 (951.42 KB, application/zip)
2016-07-07 17:02 PDT, Build Bot
no flags Details
Patch for landing (56.41 KB, patch)
2016-07-07 18:29 PDT, Ryosuke Niwa
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2016-06-06 01:19:27 PDT
See https://github.com/w3c/webcomponents/issues/513
Comment 1 Ryosuke Niwa 2016-07-07 15:26:29 PDT
Created attachment 283066 [details]
Renames the flag
Comment 2 Chris Dumez 2016-07-07 16:29:00 PDT
Comment on attachment 283066 [details]
Renames the flag

r=me
Comment 3 Build Bot 2016-07-07 16:30:22 PDT
Comment on attachment 283066 [details]
Renames the flag

Attachment 283066 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/1643363

New failing tests:
fast/shadow-dom/trusted-event-scoped-flags.html
Comment 4 Build Bot 2016-07-07 16:30:26 PDT
Created attachment 283083 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.5
Comment 5 Build Bot 2016-07-07 16:30:45 PDT
Comment on attachment 283066 [details]
Renames the flag

Attachment 283066 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/1643413

New failing tests:
editing/pasteboard/drop-text-events.html
fast/events/drag-and-drop-subframe-dataTransfer.html
editing/pasteboard/paste-text-events.html
Comment 6 Build Bot 2016-07-07 16:30:49 PDT
Created attachment 283084 [details]
Archive of layout-test-results from ews102 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 7 Build Bot 2016-07-07 16:34:41 PDT
Comment on attachment 283066 [details]
Renames the flag

Attachment 283066 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/1643370

New failing tests:
editing/pasteboard/drop-text-events.html
fast/events/drag-and-drop-subframe-dataTransfer.html
editing/pasteboard/paste-text-events.html
Comment 8 Build Bot 2016-07-07 16:34:45 PDT
Created attachment 283086 [details]
Archive of layout-test-results from ews112 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 9 Build Bot 2016-07-07 17:02:39 PDT
Comment on attachment 283066 [details]
Renames the flag

Attachment 283066 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/1643539

New failing tests:
editing/pasteboard/paste-text-events.html
Comment 10 Build Bot 2016-07-07 17:02:43 PDT
Created attachment 283091 [details]
Archive of layout-test-results from ews105 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 11 Ryosuke Niwa 2016-07-07 17:15:33 PDT
(In reply to comment #7)
> Comment on attachment 283066 [details]
> Renames the flag
> 
> Attachment 283066 [details] did not pass mac-debug-ews (mac):
> Output: http://webkit-queues.webkit.org/results/1643370
> 
> New failing tests:
> editing/pasteboard/drop-text-events.html
> fast/events/drag-and-drop-subframe-dataTransfer.html
> editing/pasteboard/paste-text-events.html

Oops, we need to add drag events & textInput event to the list of "composed" events.
Comment 12 Ryosuke Niwa 2016-07-07 18:29:20 PDT
Created attachment 283098 [details]
Patch for landing
Comment 13 WebKit Commit Bot 2016-07-07 18:58:22 PDT
Comment on attachment 283098 [details]
Patch for landing

Clearing flags on attachment: 283098

Committed r202953: <http://trac.webkit.org/changeset/202953>
Comment 14 WebKit Commit Bot 2016-07-07 18:58:26 PDT
All reviewed patches have been landed.  Closing bug.
Comment 15 Radar WebKit Bug Importer 2016-07-07 19:16:29 PDT
<rdar://problem/27237099>