Bug 158410 - [EFL] Sync EFL features with featureList.pm
Summary: [EFL] Sync EFL features with featureList.pm
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-06-05 20:40 PDT by Gyuyoung Kim
Modified: 2016-06-05 22:08 PDT (History)
3 users (show)

See Also:


Attachments
Patch (2.86 KB, patch)
2016-06-05 20:41 PDT, Gyuyoung Kim
no flags Details | Formatted Diff | Diff
Patch (2.63 KB, patch)
2016-06-05 20:42 PDT, Gyuyoung Kim
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2016-06-05 20:40:45 PDT
In OptionsEfl, some features on/off status are different with featureList.pm definitions. Sync with it.
Comment 1 Gyuyoung Kim 2016-06-05 20:41:22 PDT
Created attachment 280575 [details]
Patch
Comment 2 Gyuyoung Kim 2016-06-05 20:42:33 PDT
Created attachment 280576 [details]
Patch
Comment 3 Antonio Gomes 2016-06-05 20:56:41 PDT
Comment on attachment 280576 [details]
Patch

r=me.

Could you confirm to me if this actually changes the status of these features in regular builds?
Comment 4 Gyuyoung Kim 2016-06-05 21:30:43 PDT
(In reply to comment #3)
> Comment on attachment 280576 [details]
> Patch
> 
> r=me.
> 
> Could you confirm to me if this actually changes the status of these
> features in regular builds?

As far as I know the feature definitions of OptionEfl.cmake is just being used to add the feature name to *cmakeconfig.h* (Auto-generated cmakeconfig.h actually defines on/off status). Actual on/off status of cmakeconfig.h is done by FeatureList.pm on EFL port. So now I don't know whether we should keep on/off status in OptionEfl.cmake because it work nothing unless we build EFL port using cmake directly, not use *Tools/Scripts/build-webkit* script. If we don't need to keep the on/off status in OptionsEfl.cmake, I will try to remove it. But it seems to me that it would be good to sync with the status between OptionEfl.cmake and FeatureList.pm at the moment.
Comment 5 Gyuyoung Kim 2016-06-05 21:31:30 PDT
See also https://bugs.webkit.org/show_bug.cgi?id=143997
Comment 6 WebKit Commit Bot 2016-06-05 22:08:26 PDT
Comment on attachment 280576 [details]
Patch

Clearing flags on attachment: 280576

Committed r201707: <http://trac.webkit.org/changeset/201707>
Comment 7 WebKit Commit Bot 2016-06-05 22:08:30 PDT
All reviewed patches have been landed.  Closing bug.