Bug 158410 – [EFL] Sync EFL features with featureList.pm

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Gyuyoung Kim]

In OptionsEfl, some features on/off status are different with featureList.pm definitions. Sync with it.

[Gyuyoung Kim]

Created attachment 280575 [details]
Patch

[Gyuyoung Kim]

Created attachment 280576 [details]
Patch

[Antonio Gomes]

Comment on attachment 280576 [details]
Patch

r=me.

Could you confirm to me if this actually changes the status of these features in regular builds?

[Gyuyoung Kim]

(In reply to comment #3)
> Comment on attachment 280576 [details]
> Patch
> 
> r=me.
> 
> Could you confirm to me if this actually changes the status of these
> features in regular builds?

As far as I know the feature definitions of OptionEfl.cmake is just being used to add the feature name to *cmakeconfig.h* (Auto-generated cmakeconfig.h actually defines on/off status). Actual on/off status of cmakeconfig.h is done by FeatureList.pm on EFL port. So now I don't know whether we should keep on/off status in OptionEfl.cmake because it work nothing unless we build EFL port using cmake directly, not use *Tools/Scripts/build-webkit* script. If we don't need to keep the on/off status in OptionsEfl.cmake, I will try to remove it. But it seems to me that it would be good to sync with the status between OptionEfl.cmake and FeatureList.pm at the moment.

[Gyuyoung Kim]

See also https://bugs.webkit.org/show_bug.cgi?id=143997

[WebKit Commit Bot]

Comment on attachment 280576 [details]
Patch

Clearing flags on attachment: 280576

Committed r201707: <http://trac.webkit.org/changeset/201707>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.