Bug 158392 - REGRESSION (r201686): Web Inspector: Fix typo causing an internal error
Summary: REGRESSION (r201686): Web Inspector: Fix typo causing an internal error
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Matt Baker
Keywords: InRadar
Depends on:
Reported: 2016-06-04 21:55 PDT by Matt Baker
Modified: 2016-06-05 08:21 PDT (History)
8 users (show)

See Also:

[Patch] Proposed Fix (1.67 KB, patch)
2016-06-04 22:00 PDT, Matt Baker
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Baker 2016-06-04 21:55:38 PDT
Web Inspector: Fix typo causing an internal error. "this._heapAllocations"should be "this._heapAllocationsTimeline".

1. Open Inspector > Timelines tab
2. Open Inspector²
  => TypeError:​ undefined is not an object (evaluating 'this._heapAllocations.recordsInTimeRange')​ (at HeapAllocationsTimelineOverviewGraph.js:​60:​51)

Broke in https://trac.webkit.org/changeset/201686.
Comment 1 Radar WebKit Bug Importer 2016-06-04 21:55:53 PDT
Comment 2 Matt Baker 2016-06-04 22:00:43 PDT
Created attachment 280543 [details]
[Patch] Proposed Fix
Comment 3 Joseph Pecoraro 2016-06-04 23:11:10 PDT
You could land something like this without review.
Comment 4 WebKit Commit Bot 2016-06-05 08:21:41 PDT
Comment on attachment 280543 [details]
[Patch] Proposed Fix

Clearing flags on attachment: 280543

Committed r201698: <http://trac.webkit.org/changeset/201698>
Comment 5 WebKit Commit Bot 2016-06-05 08:21:47 PDT
All reviewed patches have been landed.  Closing bug.