Bug 158377 - REGRESSION (r201474): Should set overflow: hidden on -webkit-media-controls when placeholder is showing
Summary: REGRESSION (r201474): Should set overflow: hidden on -webkit-media-controls w...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ada Chan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-06-03 20:30 PDT by Ada Chan
Modified: 2016-06-04 17:36 PDT (History)
0 users

See Also:

Attachments
Patch (3.24 KB, patch)
2016-06-03 21:38 PDT, Ada Chan 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ada Chan 2016-06-03 20:30:08 PDT 
We added script to specify overflow: hidden on -webkit-media-controls when the placeholder is showing in r201355 but that code needs to update after r201474. After r201474, we defer removing the hidden class from inlinePlaybackPlaceholder until showInlinePlaybackPlaceholderWhenSafe(). We also need to move the code that adds the placeholder-showing class to -webkit-media-controls to that method.

<rdar://problem/26633830>
Comment 1 Ada Chan 2016-06-03 21:38:18 PDT 
Created attachment 280508 [details]
Patch
Comment 2 Ada Chan 2016-06-04 17:36:28 PDT 
Committed:
http://trac.webkit.org/changeset/201691