Bug 158363 – Web Inspector: add a keyboard shortcut to close the current tab bar item

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Blaze Burg]

Cmd-w matches Safari. You can continue to close the window with Shift-Cmd-W, like Safari.

[Blaze Burg]

<rdar://problem/22677254>

[Timothy Hatcher]

I worry if we make Command-W close the tab, it will cause developers frustration. You don't commonly close tabs in Inspector. Closing the window is more common.

We could flip the shortcuts from Safari.

[Nikita Vasilyev]

When I want to close Web Inspector I use Command-Option-I.
It matches Chrome DevTools and Firefox DevTools.

I close browser tabs with Command-W all the time
and I hardly ever close tabs Web Inspector.

[Blaze Burg]

Created attachment 280470 [details]
Proposed Fix

[Timothy Hatcher]

(In reply to comment #3)
> When I want to close Web Inspector I use Command-Option-I.
> It matches Chrome DevTools and Firefox DevTools.
> 
> I close browser tabs with Command-W all the time
> and I hardly ever close tabs Web Inspector.

I early toggle the Inspector closed with Command-Shift-I. I do close it with Command-W however.

[Nikita Vasilyev]

(In reply to comment #5)
> (In reply to comment #3)
> > When I want to close Web Inspector I use Command-Option-I.
> > It matches Chrome DevTools and Firefox DevTools.
> > 
> > I close browser tabs with Command-W all the time
> > and I hardly ever close tabs Web Inspector.
> 
> I early toggle the Inspector closed with Command-Shift-I. I do close it with
> Command-W however.

I assume you meant Command-Option-I.

Command-W closes undocked Web Inspector. In docked mode it closes
Safari's tab. In Chrome and Firefox it also closes browser's tab
when devtools are docked.

[Build Bot]

Comment on attachment 280470 [details]
Proposed Fix

Attachment 280470 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/1430791

New failing tests:
fast/scrolling/ios/scrollTo-at-page-load.html

[Build Bot]

Created attachment 280481 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.4

[Blaze Burg]

(In reply to comment #2)
> I worry if we make Command-W close the tab, it will cause developers
> frustration. You don't commonly close tabs in Inspector. Closing the window
> is more common.
> 
> We could flip the shortcuts from Safari.

This seems likely to introduce even more confusion. All browsers and tabbed document apps on OS X use Cmd-w to close a single tab, and Cmd-Shift-w to close the entire window full of tabs. The fact that Cmd-w used to work on the Inspector window is a bug. I think most people would use Cmd-Opt-I anyway.

[Timothy Hatcher]

Comment on attachment 280470 [details]
Proposed Fix

Okay, we should monitor for developer bugs complaining about this and revert if it gets to many complaints.

[WebKit Commit Bot]

Comment on attachment 280470 [details]
Proposed Fix

Clearing flags on attachment: 280470

Committed r201671: <http://trac.webkit.org/changeset/201671>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Blaze Burg]

(In reply to comment #10)
> Comment on attachment 280470 [details]
> Proposed Fix
> 
> Okay, we should monitor for developer bugs complaining about this and revert
> if it gets to many complaints.

OK

[Jon Davis]

This is going to give us a lot of backlash from developers. Changing what is now an innate pattern in their workflow will cause frustration.

And tabs in Web Inspector are not used the same way tabbed browsing is used. We should not do this.

[Timothy Hatcher]

I vote again that we flip the shortcuts, so Command-Shift-W closes tabs.

[Blaze Burg]

(In reply to comment #15)
> I vote again that we flip the shortcuts, so Command-Shift-W closes tabs.

I am unhappy that we (have and will continue to) break shortcut compatibility on this with every other tabbed document application on OS X, despite us supporting other shortcuts like next/prev, Cmd-1,9, and so forth. Normally, a user can remap key equivalents to whatever they like. But, our hands are tied because we don't have a real menu bar for Inspector. So, I give up on having nice things.

It should be possible to change this patch's shortcut to Cmd-Sh-W and have no handler for Cmd-W, which will get the default behavior of closing the window.