Bug 158358 - Add argument_count bytecode for concat
Summary: Add argument_count bytecode for concat
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Miller
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-06-03 14:19 PDT by Keith Miller
Modified: 2016-06-03 16:05 PDT (History)
4 users (show)

See Also:


Attachments
Patch (14.56 KB, patch)
2016-06-03 14:24 PDT, Keith Miller
no flags Details | Formatted Diff | Diff
Patch for landing (22.76 KB, patch)
2016-06-03 15:34 PDT, Keith Miller
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Miller 2016-06-03 14:19:44 PDT
Add argument_count bytecode for concat
Comment 1 Keith Miller 2016-06-03 14:24:11 PDT
Created attachment 280465 [details]
Patch
Comment 2 Geoffrey Garen 2016-06-03 14:27:56 PDT
Comment on attachment 280465 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=280465&action=review

r=me

> Source/JavaScriptCore/bytecode/BytecodeList.json:12
> +            { "name" : "op_js_argument_count", "length" : 2 },

I think you should leave off js here. Everything is js.
Comment 3 Keith Miller 2016-06-03 15:34:37 PDT
Created attachment 280476 [details]
Patch for landing
Comment 4 WebKit Commit Bot 2016-06-03 16:05:18 PDT
Comment on attachment 280476 [details]
Patch for landing

Clearing flags on attachment: 280476

Committed r201668: <http://trac.webkit.org/changeset/201668>
Comment 5 WebKit Commit Bot 2016-06-03 16:05:23 PDT
All reviewed patches have been landed.  Closing bug.