Bug 158353 - Miscellaneous IDBBindingUtilities cleanup
Summary: Miscellaneous IDBBindingUtilities cleanup
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords:
Depends on:
Blocks: 149117
  Show dependency tree / graph
 
Reported: 2016-06-03 13:40 PDT by Brady Eidson
Modified: 2016-06-03 14:41 PDT (History)
4 users (show)

See Also:

Attachments
Patch (31.03 KB, patch)
2016-06-03 13:51 PDT, Brady Eidson 		thorton: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2016-06-03 13:40:43 PDT 
Miscellaneous IDBBindingUtilities cleanup
Comment 1 Brady Eidson 2016-06-03 13:51:23 PDT 
Created attachment 280460 [details]
Patch
Comment 2 Tim Horton 2016-06-03 14:29:54 PDT 
Comment on attachment 280460 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=280460&action=review

> Source/WebCore/ChangeLog:8
> +        No new tests (Straight refactor, yo).

Can't you test the new errors?
Comment 3 Brady Eidson 2016-06-03 14:39:14 PDT 
(In reply to comment #2)
> Comment on attachment 280460 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=280460&action=review
> 
> > Source/WebCore/ChangeLog:8
> > +        No new tests (Straight refactor, yo).
> 
> Can't you test the new errors?

Sadly, no.

We know "ScriptExecutionContext without an ExecState" is a possibility, somehow, but it's not known to be purposefully triggerable...

If I'm wrong and somebody lets me know, I'd happily add tests.
Comment 4 Brady Eidson 2016-06-03 14:41:09 PDT 
http://trac.webkit.org/changeset/201660