Bug 158350 – Proxy.ownKeys should no longer throw an exception when duplicate keys are returned and the target is non-extensible

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Saam Barati]

See:
https://github.com/tc39/ecma262/pull/594

[Radar WebKit Bug Importer]

<rdar://problem/26626211>

[Saam Barati]

Created attachment 280467 [details]
Patch

[Mark Lam]

Comment on attachment 280467 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=280467&action=review

> Source/JavaScriptCore/runtime/ProxyObject.cpp:938
> +            bool isContainedIn = false;
> +            return isContainedIn;

Your definition of "isContainedIn" here differs from the one below.  Did you mean "isNotContainedIn" instead?

[Michael Saboff]

Comment on attachment 280467 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=280467&action=review

r=me

> Source/JavaScriptCore/runtime/ProxyObject.cpp:934
>      auto removeIfContainedInUncheckedResultKeys = [&] (UniquedStringImpl* impl) -> bool {

This lambda's name should probably change to something without "removeIf".

> Source/JavaScriptCore/runtime/ProxyObject.cpp:938
> +            bool isContainedIn = false;
> +            return isContainedIn;

Change this to "return false".

> Source/JavaScriptCore/runtime/ProxyObject.cpp:943
> +        bool isContainedIn = true;
>          return isContainedIn;

Change this to "return true".

[Saam Barati]

Comment on attachment 280467 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=280467&action=review

>> Source/JavaScriptCore/runtime/ProxyObject.cpp:934
>>      auto removeIfContainedInUncheckedResultKeys = [&] (UniquedStringImpl* impl) -> bool {
> 
> This lambda's name should probably change to something without "removeIf".

I think this would be more confusing. The function conditionally removes a key from the HashSet and the name of this lambda indicates that.

>>> Source/JavaScriptCore/runtime/ProxyObject.cpp:938
>>> +            return isContainedIn;
>> 
>> Your definition of "isContainedIn" here differs from the one below.  Did you mean "isNotContainedIn" instead?
> 
> Change this to "return false".

I'm going with an enum.

[Saam Barati]

Created attachment 280471 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 280471 [details]
Patch for landing

Clearing flags on attachment: 280471

Committed r201672: <http://trac.webkit.org/changeset/201672>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.