RESOLVED FIXED Bug 158348
ResourceResponseBase cleanup 
https://bugs.webkit.org/show_bug.cgi?id=158348
Summary ResourceResponseBase cleanup
Brady Eidson
Reported 2016-06-03 09:38:14 PDT
ResourceResponseBase cleanup
Attachments
Patch (5.22 KB, patch)
2016-06-03 09:40 PDT, Brady Eidson 		cdumez: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2016-06-03 09:40:45 PDT
Created attachment 280445 [details] Patch
Chris Dumez
Comment 2 2016-06-03 09:48:01 PDT
Comment on attachment 280445 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=280445&action=review R=me > Source/WebCore/platform/network/ResourceResponseBase.h:52 > + CrossThreadData(CrossThreadData&&) = default; We could also allow "CrossThreadData& operator=(CrossThreadData&&) = default;" > Source/WebCore/platform/network/ResourceResponseBase.h:63 > + private: No need for this I believe. > Source/WebCore/platform/network/ResourceResponseBase.h:65 > + CrossThreadData& operator =(const CrossThreadData&) = delete; Do we usually have the space before the = ?
Brady Eidson
Comment 3 2016-06-03 10:06:25 PDT
(In reply to comment #2) > Comment on attachment 280445 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=280445&action=review > > R=me > > > Source/WebCore/platform/network/ResourceResponseBase.h:65 > > + CrossThreadData& operator =(const CrossThreadData&) = delete; > > Do we usually have the space before the = ? We at least sometimes do. No style guideline on this :(
Brady Eidson
Comment 4 2016-06-03 10:08:38 PDT
http://trac.webkit.org/changeset/201647
Note You need to log in before you can comment on or make changes to this bug.