Bug 158348 - ResourceResponseBase cleanup
Summary: ResourceResponseBase cleanup
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-06-03 09:38 PDT by Brady Eidson
Modified: 2016-06-03 10:08 PDT (History)
1 user (show)

See Also:


Attachments
Patch (5.22 KB, patch)
2016-06-03 09:40 PDT, Brady Eidson
cdumez: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2016-06-03 09:38:14 PDT
ResourceResponseBase cleanup
Comment 1 Brady Eidson 2016-06-03 09:40:45 PDT
Created attachment 280445 [details]
Patch
Comment 2 Chris Dumez 2016-06-03 09:48:01 PDT
Comment on attachment 280445 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=280445&action=review

R=me

> Source/WebCore/platform/network/ResourceResponseBase.h:52
> +        CrossThreadData(CrossThreadData&&) = default;

We could also allow "CrossThreadData& operator=(CrossThreadData&&) = default;"

> Source/WebCore/platform/network/ResourceResponseBase.h:63
> +    private:

No need for this I believe.

> Source/WebCore/platform/network/ResourceResponseBase.h:65
> +        CrossThreadData& operator =(const CrossThreadData&) = delete;

Do we usually have the space before the = ?
Comment 3 Brady Eidson 2016-06-03 10:06:25 PDT
(In reply to comment #2)
> Comment on attachment 280445 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=280445&action=review
> 
> R=me
> 
> > Source/WebCore/platform/network/ResourceResponseBase.h:65
> > +        CrossThreadData& operator =(const CrossThreadData&) = delete;
> 
> Do we usually have the space before the = ?

We at least sometimes do. No style guideline on this :(
Comment 4 Brady Eidson 2016-06-03 10:08:38 PDT
http://trac.webkit.org/changeset/201647