Bug 158317 – [iOS]: Some JSC stress tests fail running out of executable memory when the LLInt is disabled

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Michael Saboff]

Some of the stress tests need so much code alive that they run out of executable memory when the LLInt is disabled.  There were similar issues with the JS LayoutTests.  For these tests, we should not run the "noLLInt" variant.

The tests in question are
    ARM - stress/arrowfunction-lexical-bind-superproperty.js
    ARM & ARM64 - stress/proxy-revoke.js

<rdar://problem/26605951>
<rdar://problem/26605961>

[Michael Saboff]

Created attachment 280370 [details]
Patch

[Saam Barati]

Comment on attachment 280370 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=280370&action=review

> Tools/Scripts/run-jsc-stress-tests:937
> +    if $quickMode
> +        defaultQuickRun
> +    else
> +        runDefault
> +        runAlwaysTriggerCopyPhase
> +        if $jitTests
> +            runNoCJITValidatePhases
> +            runDFGEager
> +            runDFGEagerNoCJITValidate
> +            runDefaultFTL
> +            runFTLNoCJITValidate
> +            runFTLNoCJITNoPutStackValidate
> +            runFTLNoCJITNoInlineValidate
> +            runFTLEager
> +            runFTLEagerNoCJITValidate
> +            runFTLNoCJITSmallPool
> +            runDFGMaximalFlushPhase
> +        end
> +    end
> +end

I wish we had a way to just set some extra flags on every run so we don't have to copy defaultRun here.
Maybe we could add something like EXTRA_OPTIONS = [];
And here, you can set those options, and then set them back to empty after the run.
And each run() can add EXTRA_OPTIONS

[Michael Saboff]

Committed r201618: <http://trac.webkit.org/changeset/201618>

[Michael Saboff]

(In reply to comment #2)
> Comment on attachment 280370 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=280370&action=review
> 
> > Tools/Scripts/run-jsc-stress-tests:937
> > +    if $quickMode
> > +        defaultQuickRun
> > +    else
> > +        runDefault
> > +        runAlwaysTriggerCopyPhase
> > +        if $jitTests
> > +            runNoCJITValidatePhases
> > +            runDFGEager
> > +            runDFGEagerNoCJITValidate
> > +            runDefaultFTL
> > +            runFTLNoCJITValidate
> > +            runFTLNoCJITNoPutStackValidate
> > +            runFTLNoCJITNoInlineValidate
> > +            runFTLEager
> > +            runFTLEagerNoCJITValidate
> > +            runFTLNoCJITSmallPool
> > +            runDFGMaximalFlushPhase
> > +        end
> > +    end
> > +end
> 
> I wish we had a way to just set some extra flags on every run so we don't
> have to copy defaultRun here.
> Maybe we could add something like EXTRA_OPTIONS = [];
> And here, you can set those options, and then set them back to empty after
> the run.
> And each run() can add EXTRA_OPTIONS

I was thinking we could make a more general additive process.  defaultRun would run everything, but it would be composed of subgroups.  For cases like this, be just run the selected subgroups.