Bug 158316 – Clean up how StackVisitor dumps its frames.

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Mark Lam]

Update to dump with a PrintStream.

[Mark Lam]

Created attachment 280388 [details]
proposed patch.

[WebKit Commit Bot]

Attachment 280388 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/interpreter/StackVisitor.h:91:  The parameter name "indent" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Keith Miller]

Comment on attachment 280388 [details]
proposed patch.

r=me.

[Mark Lam]

Thanks for the review.  Fixed style issue and landed in r201641: <http://trac.webkit.org/r201641>.

[Ryan Haddad]

This change appears to have broken the CLoop build:
https://build.webkit.org/builders/Apple%20Yosemite%20LLINT%20CLoop%20%28BuildAndTest%29/builds/

/Volumes/Data/slave/yosemite-cloop-debug/build/Source/JavaScriptCore/interpreter/StackVisitor.h:92:43: error: no type named 'function' in namespace 'std'; did you mean '::Function'?
/Volumes/Data/slave/yosemite-cloop-debug/build/Source/JavaScriptCore/interpreter/StackVisitor.h:92:56: error: expected ')'
/Volumes/Data/slave/yosemite-cloop-debug/build/Source/JavaScriptCore/interpreter/StackVisitor.cpp:349:5: error: no matching member function for call to 'dump'
/Volumes/Data/slave/yosemite-cloop-debug/build/Source/JavaScriptCore/interpreter/StackVisitor.cpp:352:27: error: out-of-line definition of 'dump' does not match any declaration in 'JSC::StackVisitor::Frame'

[Mark Lam]

(In reply to comment #5)
> This change appears to have broken the CLoop build:
> https://build.webkit.org/builders/
> Apple%20Yosemite%20LLINT%20CLoop%20%28BuildAndTest%29/builds/
> 
> /Volumes/Data/slave/yosemite-cloop-debug/build/Source/JavaScriptCore/
> interpreter/StackVisitor.h:92:43: error: no type named 'function' in
> namespace 'std'; did you mean '::Function'?
> /Volumes/Data/slave/yosemite-cloop-debug/build/Source/JavaScriptCore/
> interpreter/StackVisitor.h:92:56: error: expected ')'
> /Volumes/Data/slave/yosemite-cloop-debug/build/Source/JavaScriptCore/
> interpreter/StackVisitor.cpp:349:5: error: no matching member function for
> call to 'dump'
> /Volumes/Data/slave/yosemite-cloop-debug/build/Source/JavaScriptCore/
> interpreter/StackVisitor.cpp:352:27: error: out-of-line definition of 'dump'
> does not match any declaration in 'JSC::StackVisitor::Frame'

I will fix.

[Mark Lam]

CLoop fix landed in r201646: <http://trac.webkit.org/r201646>.