Bug 158316 - Clean up how StackVisitor dumps its frames.
Summary: Clean up how StackVisitor dumps its frames.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-06-02 14:33 PDT by Mark Lam
Modified: 2016-06-03 09:49 PDT (History)
8 users (show)

See Also:

Attachments
proposed patch. (18.73 KB, patch)
2016-06-02 17:14 PDT, Mark Lam 		keith_miller: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2016-06-02 14:33:56 PDT 
Update to dump with a PrintStream.
Comment 1 Mark Lam 2016-06-02 17:14:01 PDT 
Created attachment 280388 [details]
proposed patch.
Comment 2 WebKit Commit Bot 2016-06-02 17:15:27 PDT 
Attachment 280388 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/interpreter/StackVisitor.h:91:  The parameter name "indent" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Keith Miller 2016-06-02 17:24:11 PDT 
Comment on attachment 280388 [details]
proposed patch.

r=me.
Comment 4 Mark Lam 2016-06-03 07:52:56 PDT 
Thanks for the review.  Fixed style issue and landed in r201641: <http://trac.webkit.org/r201641>.
Comment 5 Ryan Haddad 2016-06-03 09:30:00 PDT 
This change appears to have broken the CLoop build:
https://build.webkit.org/builders/Apple%20Yosemite%20LLINT%20CLoop%20%28BuildAndTest%29/builds/

/Volumes/Data/slave/yosemite-cloop-debug/build/Source/JavaScriptCore/interpreter/StackVisitor.h:92:43: error: no type named 'function' in namespace 'std'; did you mean '::Function'?
/Volumes/Data/slave/yosemite-cloop-debug/build/Source/JavaScriptCore/interpreter/StackVisitor.h:92:56: error: expected ')'
/Volumes/Data/slave/yosemite-cloop-debug/build/Source/JavaScriptCore/interpreter/StackVisitor.cpp:349:5: error: no matching member function for call to 'dump'
/Volumes/Data/slave/yosemite-cloop-debug/build/Source/JavaScriptCore/interpreter/StackVisitor.cpp:352:27: error: out-of-line definition of 'dump' does not match any declaration in 'JSC::StackVisitor::Frame'
Comment 6 Mark Lam 2016-06-03 09:30:42 PDT 
(In reply to comment #5)
> This change appears to have broken the CLoop build:
> https://build.webkit.org/builders/
> Apple%20Yosemite%20LLINT%20CLoop%20%28BuildAndTest%29/builds/
> 
> /Volumes/Data/slave/yosemite-cloop-debug/build/Source/JavaScriptCore/
> interpreter/StackVisitor.h:92:43: error: no type named 'function' in
> namespace 'std'; did you mean '::Function'?
> /Volumes/Data/slave/yosemite-cloop-debug/build/Source/JavaScriptCore/
> interpreter/StackVisitor.h:92:56: error: expected ')'
> /Volumes/Data/slave/yosemite-cloop-debug/build/Source/JavaScriptCore/
> interpreter/StackVisitor.cpp:349:5: error: no matching member function for
> call to 'dump'
> /Volumes/Data/slave/yosemite-cloop-debug/build/Source/JavaScriptCore/
> interpreter/StackVisitor.cpp:352:27: error: out-of-line definition of 'dump'
> does not match any declaration in 'JSC::StackVisitor::Frame'

I will fix.
Comment 7 Mark Lam 2016-06-03 09:49:19 PDT 
CLoop fix landed in r201646: <http://trac.webkit.org/r201646>.