Bug 158312 - [MSE] Adopt +[AVStreamDataParser outputMIMECodecParameterForInputMIMECodecParameter:]
Summary: [MSE] Adopt +[AVStreamDataParser outputMIMECodecParameterForInputMIMECodecPar...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-06-02 12:58 PDT by Jer Noble
Modified: 2016-06-24 10:46 PDT (History)
3 users (show)

See Also:

Attachments
Patch (2.54 KB, patch)
2016-06-06 12:37 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch (10.46 KB, patch)
2016-06-22 10:21 PDT, Jer Noble 		eric.carlson: review+
Details | Formatted Diff | Diff
Patch for landing (10.62 KB, patch)
2016-06-23 23:33 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch for landing (10.15 KB, patch)
2016-06-24 09:41 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch for landing (10.20 KB, patch)
2016-06-24 10:15 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2016-06-02 12:58:39 PDT 
[MSE] Adopt +[AVStreamDataParser outputMIMECodecParameterForInputMIMECodecParameter:]
Comment 1 Alexey Proskuryakov 2016-06-03 09:45:43 PDT 
rdar://problem/26258555
Comment 2 Jer Noble 2016-06-06 12:37:51 PDT 
Created attachment 280618 [details]
Patch
Comment 3 Darin Adler 2016-06-06 18:27:14 PDT 
Comment on attachment 280618 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=280618&action=review

> Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:129
> +@interface AVStreamDataParser : NSObject
> ++ (NSString *)outputMIMECodecParameterForInputMIMECodecParameter:(NSString *)inputMIMECodecParameter;
> +@end

We normally put these in SPI.h headers, not inside implementation files.

> Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:270
> +    NSString *typeString = [NSString stringWithFormat:@"%@; codecs=\"%@\"", (NSString *)parameters.type, (NSString *)outputCodecs];

No reason for the (NSString *) cast on outputCodecs any more.
Comment 4 Jer Noble 2016-06-09 13:47:13 PDT 
(In reply to comment #3)
> Comment on attachment 280618 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=280618&action=review
> 
> > Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:129
> > +@interface AVStreamDataParser : NSObject
> > ++ (NSString *)outputMIMECodecParameterForInputMIMECodecParameter:(NSString *)inputMIMECodecParameter;
> > +@end
> 
> We normally put these in SPI.h headers, not inside implementation files.
> 
> > Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:270
> > +    NSString *typeString = [NSString stringWithFormat:@"%@; codecs=\"%@\"", (NSString *)parameters.type, (NSString *)outputCodecs];
> 
> No reason for the (NSString *) cast on outputCodecs any more.

No, I think that for variable-length argument lists, the NSString* casts are really necessary.
Comment 5 Jer Noble 2016-06-22 10:21:17 PDT 
Created attachment 281849 [details]
Patch
Comment 6 Eric Carlson 2016-06-22 10:25:08 PDT 
Comment on attachment 281849 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=281849&action=review

> Source/WebCore/ChangeLog:5
> +

Radar url?
Comment 7 Jer Noble 2016-06-23 23:33:43 PDT 
Created attachment 281960 [details]
Patch for landing
Comment 8 Jer Noble 2016-06-24 09:41:45 PDT 
Created attachment 281987 [details]
Patch for landing
Comment 9 Jer Noble 2016-06-24 10:15:05 PDT 
Created attachment 281996 [details]
Patch for landing
Comment 10 Jer Noble 2016-06-24 10:46:36 PDT 
Committed r202429: <http://trac.webkit.org/changeset/202429>