Patch forthcoming.
Created attachment 280342 [details] the patch
Attachment 280342 [details] did not pass style-queue: ERROR: Source/WTF/wtf/Locker.h:48: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 280342 [details] the patch r=me. Although, the implicit cast nature of the NoLockingNecessaryTag still terrifies me. I dread the day I see Locker(someIntegralVariableWithANameThatLooksTooCloseToALock)
Landed in http://trac.webkit.org/changeset/201605
(In reply to comment #3) > Comment on attachment 280342 [details] > the patch > > r=me. Although, the implicit cast nature of the NoLockingNecessaryTag still > terrifies me. I dread the day I see > Locker(someIntegralVariableWithANameThatLooksTooCloseToALock) Maybe we can solve that by having an overload of Locker that takes int and asserts?
> Maybe we can solve that by having an overload of Locker that takes int and > asserts? That seems like a good idea. rs=me.
(In reply to comment #6) > > Maybe we can solve that by having an overload of Locker that takes int and > > asserts? > > That seems like a good idea. rs=me. Landed in http://trac.webkit.org/changeset/201609
Can it just be an overload with "= delete"?
(In reply to comment #8) > Can it just be an overload with "= delete"? Aw snap! I'll do that.
(In reply to comment #9) > (In reply to comment #8) > > Can it just be an overload with "= delete"? > > Aw snap! I'll do that. RS to do this or do you want to see the patch?
(In reply to comment #10) > (In reply to comment #9) > > (In reply to comment #8) > > > Can it just be an overload with "= delete"? > > > > Aw snap! I'll do that. > > RS to do this or do you want to see the patch? Saam rubber stamped this in person. Landed here: http://trac.webkit.org/changeset/201611