Bug 158301 - [GTK] Update YouCompleteMe script to make all include paths absolute
Summary: [GTK] Update YouCompleteMe script to make all include paths absolute
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-06-02 03:41 PDT by youenn fablet
Modified: 2016-06-03 08:39 PDT (History)
5 users (show)

See Also:


Attachments
Patch (1.34 KB, patch)
2016-06-02 03:43 PDT, youenn fablet
no flags Details | Formatted Diff | Diff
Patch for landing (1.51 KB, patch)
2016-06-03 08:09 PDT, youenn fablet
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2016-06-02 03:41:29 PDT
YCM does not make all include paths absolute.
At least on my setup, dependencies headers are not always found.
Comment 1 youenn fablet 2016-06-02 03:43:54 PDT
Created attachment 280328 [details]
Patch
Comment 2 Michael Catanzaro 2016-06-02 06:25:28 PDT
What is this script?
Comment 3 youenn fablet 2016-06-02 06:30:11 PDT
(In reply to comment #2)
> What is this script?

It allows https://github.com/Valloric/YouCompleteMe working properly for WebKit source base.
Comment 4 Michael Catanzaro 2016-06-02 06:38:37 PDT
Comment on attachment 280328 [details]
Patch

OK, rubber stamp, but please separately add a comment to the top of this script to indicate what it's for.
Comment 5 youenn fablet 2016-06-02 06:56:39 PDT
(In reply to comment #4)
> Comment on attachment 280328 [details]
> Patch
> 
> OK, rubber stamp, but please separately add a comment to the top of this
> script to indicate what it's for.

OK, thanks, I'll clarify the changelog.

Martin, changseok, would you be able to check that the change is not disrupting your setup?
Comment 6 youenn fablet 2016-06-03 08:09:33 PDT
Created attachment 280444 [details]
Patch for landing
Comment 7 WebKit Commit Bot 2016-06-03 08:39:18 PDT
Comment on attachment 280444 [details]
Patch for landing

Clearing flags on attachment: 280444

Committed r201642: <http://trac.webkit.org/changeset/201642>
Comment 8 WebKit Commit Bot 2016-06-03 08:39:24 PDT
All reviewed patches have been landed.  Closing bug.