Bug 158296 - [Win] Fetch API tests are failing.
Summary: [Win] Fetch API tests are failing.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-06-02 00:58 PDT by Per Arne Vollan
Modified: 2016-06-02 21:36 PDT (History)
2 users (show)

See Also:


Attachments
Patch (1.35 KB, patch)
2016-06-02 01:05 PDT, Per Arne Vollan
no flags Details | Formatted Diff | Diff
Patch (4.48 KB, patch)
2016-06-02 03:00 PDT, Per Arne Vollan
no flags Details | Formatted Diff | Diff
Patch (5.70 KB, patch)
2016-06-02 14:01 PDT, Per Arne Vollan
achristensen: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2016-06-02 00:58:25 PDT
We also need to enable this feature in runtime.
Comment 1 Per Arne Vollan 2016-06-02 01:05:10 PDT
Created attachment 280316 [details]
Patch
Comment 2 Per Arne Vollan 2016-06-02 03:00:05 PDT
Created attachment 280323 [details]
Patch
Comment 3 Alex Christensen 2016-06-02 13:18:01 PDT
Comment on attachment 280323 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=280323&action=review

> Source/WebKit/win/WebPreferences.cpp:294
> +    CFDictionaryAddValue(defaults, CFSTR(WebKitFetchAPIEnabledPreferenceKey), kCFBooleanTrue);

Fetch isn't done yet.  I think it should be disabled by default and turned on in DumpRenderTree.
Comment 4 Per Arne Vollan 2016-06-02 14:01:58 PDT
Created attachment 280364 [details]
Patch
Comment 5 Per Arne Vollan 2016-06-02 14:04:32 PDT
(In reply to comment #3)
> Comment on attachment 280323 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=280323&action=review
> 
> > Source/WebKit/win/WebPreferences.cpp:294
> > +    CFDictionaryAddValue(defaults, CFSTR(WebKitFetchAPIEnabledPreferenceKey), kCFBooleanTrue);
> 
> Fetch isn't done yet.  I think it should be disabled by default and turned
> on in DumpRenderTree.

Thanks for reviewing :) Updated patch.

It is correct to add the new preference methods to the IWebPreferencesPrivate3 class?
Comment 6 Alex Christensen 2016-06-02 14:18:06 PDT
Comment on attachment 280364 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=280364&action=review

> Source/WebKit/win/WebView.cpp:5035
> +    // TODO: Add preferences for the runtime enabled features.

FIXME seems to be preferred in WebKit.
Comment 7 Alex Christensen 2016-06-02 14:20:08 PDT
(In reply to comment #5)
> It is correct to add the new preference methods to the
> IWebPreferencesPrivate3 class?
I think so.  We add another one after each release to keep the interfaces backwards compatible.
Comment 8 Per Arne Vollan 2016-06-02 21:36:27 PDT
Committed r201634: <https://trac.webkit.org/changeset/201634>