We also need to enable this feature in runtime.
Created attachment 280316 [details] Patch
Created attachment 280323 [details] Patch
Comment on attachment 280323 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=280323&action=review > Source/WebKit/win/WebPreferences.cpp:294 > + CFDictionaryAddValue(defaults, CFSTR(WebKitFetchAPIEnabledPreferenceKey), kCFBooleanTrue); Fetch isn't done yet. I think it should be disabled by default and turned on in DumpRenderTree.
Created attachment 280364 [details] Patch
(In reply to comment #3) > Comment on attachment 280323 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=280323&action=review > > > Source/WebKit/win/WebPreferences.cpp:294 > > + CFDictionaryAddValue(defaults, CFSTR(WebKitFetchAPIEnabledPreferenceKey), kCFBooleanTrue); > > Fetch isn't done yet. I think it should be disabled by default and turned > on in DumpRenderTree. Thanks for reviewing :) Updated patch. It is correct to add the new preference methods to the IWebPreferencesPrivate3 class?
Comment on attachment 280364 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=280364&action=review > Source/WebKit/win/WebView.cpp:5035 > + // TODO: Add preferences for the runtime enabled features. FIXME seems to be preferred in WebKit.
(In reply to comment #5) > It is correct to add the new preference methods to the > IWebPreferencesPrivate3 class? I think so. We add another one after each release to keep the interfaces backwards compatible.
Committed r201634: <https://trac.webkit.org/changeset/201634>