Bug 158294 – Refactor showModalDialog handling in JSDOMWindowCustom

• Status: RESOLVED
• Resolution: FIXED
• Component: Bindings

[Gavin Barraclough]

The way this is currently implemented, for accessing the showModalDialog property there is effectively a duplication of the tail of the function modified to call Base::getOwnPropertySlot instead of getStaticPropertySlot. It does so based on the assumption that Base::getOwnPropertySlot is not going to search the static tables (containing the property we wish to omit).

However as a part of bug #158178 I plan to change it such that Base::getOwnPropertySlot does also search the static tables. Refactor this code to no longer depend on Base::getOwnPropertySlot bypassing the static tables. Always perform a lookup that will check both property storage & static tables. If the object does contain the property, check explicitly for the value we're intending to suppress.

[Gavin Barraclough]

Created attachment 280428 [details]
Fix

[WebKit Commit Bot]

Attachment 280428 [details] did not pass style-queue:


ERROR: Source/WebCore/bindings/js/JSDOMWindowCustom.cpp:58:  The parameter name "state" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/bindings/js/JSDOMWindowCustom.cpp:246:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 2 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Gavin Barraclough]

Committed revision 201638.