Bug 158292 – Modernize various lambda captures

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Chris Dumez]

Modernize various lambda captures, especially the ones unnecessarily allocating objects on the heap and destroying them in the lambda.

[Chris Dumez]

Created attachment 280308 [details]
Patch

[WebKit Commit Bot]

Attachment 280308 [details] did not pass style-queue:


ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCache.cpp:523:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCache.h:116:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/NetworkProcess.cpp:311:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/NetworkProcess.cpp:415:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 4 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Brady Eidson]

Comment on attachment 280308 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=280308&action=review

Reviewing this urged me to file https://bugs.webkit.org/show_bug.cgi?id=158293

r+ as long as cleaning up the build errors doesn't substantially change the patch.

> Source/WebCore/Modules/websockets/ThreadableWebSocketChannelClientWrapper.cpp:-173
> -    String messageCopy = message.isolatedCopy();
> -    m_pendingTasks.append(std::make_unique<ScriptExecutionContext::Task>([this, message] (ScriptExecutionContext&) {

AGGGGH! This one was straight up wrong!!! :(

[Chris Dumez]

Created attachment 280333 [details]
Patch

[WebKit Commit Bot]

Attachment 280333 [details] did not pass style-queue:


ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCache.cpp:523:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCache.h:116:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/NetworkProcess.cpp:311:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/NetworkProcess.cpp:415:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 4 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Chris Dumez]

Hmm.

  "WTF::RefPtr<WebKit::NetworkProcess::fetchWebsiteData(WebCore::SessionID, WTF::OptionSet<WebKit::WebsiteDataType>, WTF::OptionSet<WebKit::WebsiteDataFetchOption>, unsigned long long)::CallbackAggregator>::RefPtr(WTF::RefPtr<WebKit::NetworkProcess::fetchWebsiteData(WebCore::SessionID, WTF::OptionSet<WebKit::WebsiteDataType>, WTF::OptionSet<WebKit::WebsiteDataFetchOption>, unsigned long long)::CallbackAggregator> const&)", referenced from:
      WebKit::NetworkProcess::fetchWebsiteData(WebCore::SessionID, WTF::OptionSet<WebKit::WebsiteDataType>, WTF::OptionSet<WebKit::WebsiteDataFetchOption>, unsigned long long) in NetworkProcess.o
ld: symbol(s) not found for architecture x86_64

But I did not modify fetchWebsiteData() or any of its call sites. Weird.

[Chris Dumez]

Created attachment 280335 [details]
Patch

[WebKit Commit Bot]

Attachment 280335 [details] did not pass style-queue:


ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCache.cpp:524:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCache.h:117:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/NetworkProcess.cpp:311:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/NetworkProcess.cpp:415:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 4 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Chris Dumez]

Created attachment 280336 [details]
Patch

[WebKit Commit Bot]

Attachment 280336 [details] did not pass style-queue:


ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCache.cpp:524:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/cache/NetworkCache.h:117:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/NetworkProcess.cpp:311:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/NetworkProcess.cpp:355:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/NetworkProcess.cpp:369:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/NetworkProcess/NetworkProcess.cpp:415:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 6 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Chris Dumez]

Comment on attachment 280336 [details]
Patch

Clearing flags on attachment: 280336

Committed r201602: <http://trac.webkit.org/changeset/201602>

[Chris Dumez]

All reviewed patches have been landed.  Closing bug.