There are 3 places where NSAttachmentCharacter lives in WebCore
<rdar://problem/26591150>
Created attachment 280286 [details] Patch
Attachment 280286 [details] did not pass style-queue: ERROR: Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:60: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/ChangeLog:9: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 2 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 280287 [details] Patch
Attachment 280287 [details] did not pass style-queue: ERROR: Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:60: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 280287 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=280287&action=review > Source/WebCore/platform/mac/WebNSAttributedStringExtras.h:33 > +#if TARGET_OS_IOS > +enum { > + NSAttachmentCharacter = 0xfffc /* To denote attachments. */ > +}; > +#endif It seems strange for us to define this inside the WebCore namespace. This is defined in NSTextAttachment.h; can we use that instead? Is that not available on iOS?
(In reply to comment #6) > Comment on attachment 280287 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=280287&action=review > > > Source/WebCore/platform/mac/WebNSAttributedStringExtras.h:33 > > +#if TARGET_OS_IOS > > +enum { > > + NSAttachmentCharacter = 0xfffc /* To denote attachments. */ > > +}; > > +#endif > > It seems strange for us to define this inside the WebCore namespace. > > This is defined in NSTextAttachment.h; can we use that instead? Is that not > available on iOS? Correct, not available on iOS for some reason
Created attachment 281133 [details] BUG 158287
Created attachment 281134 [details] http://www.bugs.webkit.org
Comment on attachment 281134 [details] http://www.bugs.webkit.org Edit Attachment
Comment on attachment 281134 [details] http://www.bugs.webkit.org Edit attachment
(In reply to comment #1) > <rdar://problem/26591150>
Comment on attachment 281134 [details] http://www.bugs.webkit.org Spam?
Comment on attachment 280287 [details] Patch We should not define this in the WebCore namespace. We should just define it in the global namespace on iOS to match Mac, and then we can remove it when eventually it shows up in the iOS SDK as well.