WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
Bug 158282
Web Inspector: memory category timelines should all use the same y-scale
https://bugs.webkit.org/show_bug.cgi?id=158282
Summary
Web Inspector: memory category timelines should all use the same y-scale
Blaze Burg
Reported
2016-06-01 16:33:22 PDT
Currently, they are all independently scaled to the timeline height based on the visible data. So, if a page has 1MB of images, its scale is [0, 2] and it always renders as 50% * height. Another category could have range [0, 100MB] and 50% * height would represent 50MB. So it currently isn't possible to visually compare different category timelines. This seems like it strictly reduces the usefulness of the split out timelines. I think they should retain the relative sizes like in the stacked line graph, which seems to be scaled to [0, max(sum(categories)]. We probably instead want the scale to be [0, max(categories)] so that the max-value category reaches 100% * height at its max value.
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2016-06-01 16:34:57 PDT
<
rdar://problem/26589754
>
Joseph Pecoraro
Comment 2
2016-06-01 17:48:31 PDT
Hmm, the intent was that the individual timeline graphs emphasize the change in an individual category in the selected time range. If one category dominates the others, then scaling the others (which may have changes of 50%-100%) would be unnoticeable. Maybe that isn't too bad, given the one category is so much later, but it makes debugging the non-largest category more difficult.
Joseph Pecoraro
Comment 3
2016-06-01 17:52:38 PDT
To elaborate. A stacked line chart is great for showing the combined data over time. However, it is very difficult to see the changes to an individual category. That is what the individual timelines in the timeline view is meant to show: the relative changes for an individual category. If you were to redraw the individual categories at the same scale as the overview's stacked line chart, then, to me, it would seem rather pointless to draw it again.
Blaze Burg
Comment 4
2016-06-01 20:32:12 PDT
Well, we could add a toggle to switch between the two scales.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug