Bug 158282 - Web Inspector: memory category timelines should all use the same y-scale
Summary: Web Inspector: memory category timelines should all use the same y-scale
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-06-01 16:33 PDT by BJ Burg
Modified: 2016-12-13 15:37 PST (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description BJ Burg 2016-06-01 16:33:22 PDT
Currently, they are all independently scaled to the timeline height based on the visible data. So, if a page has 1MB of images, its scale is [0, 2] and it always renders as 50% * height. Another category could have range [0, 100MB] and 50% * height would represent 50MB. So it currently isn't possible to visually compare different category timelines. This seems like it strictly reduces the usefulness of the split out timelines.

I think they should retain the relative sizes like in the stacked line graph, which seems to be scaled to [0, max(sum(categories)]. We probably instead want the scale to be [0, max(categories)] so that the max-value category reaches 100% * height at its max value.
Comment 1 Radar WebKit Bug Importer 2016-06-01 16:34:57 PDT
<rdar://problem/26589754>
Comment 2 Joseph Pecoraro 2016-06-01 17:48:31 PDT
Hmm, the intent was that the individual timeline graphs emphasize the change in an individual category in the selected time range. If one category dominates the others, then scaling the others (which may have changes of 50%-100%) would be unnoticeable. Maybe that isn't too bad, given the one category is so much later, but it makes debugging the non-largest category more difficult.
Comment 3 Joseph Pecoraro 2016-06-01 17:52:38 PDT
To elaborate. A stacked line chart is great for showing the combined data over time. However, it is very difficult to see the changes to an individual category. That is what the individual timelines in the timeline view is meant to show: the relative changes for an individual category.

If you were to redraw the individual categories at the same scale as the overview's stacked line chart, then, to me, it would seem rather pointless to draw it again.
Comment 4 BJ Burg 2016-06-01 20:32:12 PDT
Well, we could add a toggle to switch between the two scales.