Bug 158262 – JSON.stringify replacer function calls with numeric array indices

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Brian C]

Since

> typeof Object.keys(['a'])[0] === 'string';

I would expect

> JSON.stringify(['a'], function(key, value) {
>   console.log(typeof key);
>   return value;
> });

to log "string" twice. Instead it logs "string" and then "number".

Chrome and Firefox log "string" twice, as expected.

[Benjamin Poulain]

I'll have a look.

[Radar WebKit Bug Importer]

<rdar://problem/26613876>

[Benjamin Poulain]

Created attachment 280396 [details]
Patch

[Benjamin Poulain]

Created attachment 280397 [details]
Patch

[Build Bot]

Comment on attachment 280397 [details]
Patch

Attachment 280397 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/1426046

New failing tests:
js/dom/JSON-stringify.html

[Build Bot]

Created attachment 280405 [details]
Archive of layout-test-results from ews101 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 280397 [details]
Patch

Attachment 280397 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/1426058

New failing tests:
js/dom/JSON-stringify.html

[Build Bot]

Created attachment 280407 [details]
Archive of layout-test-results from ews105 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 280397 [details]
Patch

Attachment 280397 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/1426053

New failing tests:
js/dom/JSON-stringify.html

[Build Bot]

Created attachment 280411 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.4

[Build Bot]

Comment on attachment 280397 [details]
Patch

Attachment 280397 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/1426057

New failing tests:
js/dom/JSON-stringify.html

[Build Bot]

Created attachment 280414 [details]
Archive of layout-test-results from ews117 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Benjamin Poulain]

Comment on attachment 280397 [details]
Patch

Looks like a test needs an update. I'll do that tomorrow.

[Benjamin Poulain]

Created attachment 280485 [details]
Patch

[Saam Barati]

Comment on attachment 280485 [details]
Patch

LGTM

[WebKit Commit Bot]

Comment on attachment 280485 [details]
Patch

Clearing flags on attachment: 280485

Committed r201674: <http://trac.webkit.org/changeset/201674>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.