Bug 158247 – Video elements are painted twice, in PaintPhaseForeground and PaintPhaseSelfOutline

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Fujii Hironori]

Video elements are painted twice, in PaintPhaseForeground and PaintPhaseSelfOutline

In r105247 <http://trac.webkit.org/changeset/105247>, a following change has been made.
http://trac.webkit.org/changeset/105247/trunk/Source/WebCore/rendering/RenderReplaced.cpp

> Index: trunk/Source/WebCore/rendering/RenderReplaced.cpp
> ===================================================================
> --- a/trunk/Source/WebCore/rendering/RenderReplaced.cpp
> +++ b/trunk/Source/WebCore/rendering/RenderReplaced.cpp
> @@ -123,5 +123,5 @@
>          paintOutline(paintInfo.context, paintRect);
>      
> -    if (paintInfo.phase != PaintPhaseForeground && paintInfo.phase != PaintPhaseSelection)
> +    if (paintInfo.phase != PaintPhaseForeground && paintInfo.phase != PaintPhaseSelection && !canHaveChildren())
>          return;

Before this change, it was ensured paintReplaced is called only in PaintPhaseForeground and PaintPhaseSelection.
After this change, paintReplaced is called even in PaintPhaseSelfOutline if canHaveChildren().

[Fujii Hironori]

Blink:

Issue 485644 - chromium - Outline of replaced object is painted twice

Issue: http://crbug.com/485644
Review: https://codereview.chromium.org/1129973003
Commit: https://src.chromium.org/viewvc/blink?revision=195140&view=revision

[Fujii Hironori]

Created attachment 280227 [details]
Patch

[Simon Fraser (smfr)]

You should be able to detect the double-painting by using border or background with alpha in a ref test, right?

[Fujii Hironori]

Created attachment 280671 [details]
Patch

Thank you for review. I added a test case.

[Fujii Hironori]

Created attachment 280675 [details]
outline-replaced-elements-offset-actual.png before fixing

All outline has a negatie offset in this test case.
All outline should be painted on a element.
But, only video element's outline was hidden by the poster image.

[Build Bot]

Comment on attachment 280671 [details]
Patch

Attachment 280671 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/1456670

New failing tests:
fast/replaced/outline-replaced-elements-offset.html

[Build Bot]

Created attachment 280680 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.4

[Fujii Hironori]

Created attachment 280681 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 280681 [details]
Patch

Clearing flags on attachment: 280681

Committed r201752: <http://trac.webkit.org/changeset/201752>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.