[EME] Sound continues playing when video's src is changed
Created attachment 280176 [details] Patch
Created attachment 280180 [details] Patch
Comment on attachment 280180 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=280180&action=review > Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:2598 > + std::unique_ptr<CDMSessionAVFoundationObjC> session = std::make_unique<CDMSessionAVFoundationObjC>(this, client); Nit: can you use "auto" here?
(In reply to comment #3) > Comment on attachment 280180 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=280180&action=review > > > Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:2598 > > + std::unique_ptr<CDMSessionAVFoundationObjC> session = std::make_unique<CDMSessionAVFoundationObjC>(this, client); > > Nit: can you use "auto" here? Sure can!
Committed r201524: <http://trac.webkit.org/changeset/201524>
<rdar://problem/26248690>
Comment on attachment 280180 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=280180&action=review > Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:2600 > + return WTFMove(session); No need for WTFMove here.