Bug 158233 - [EME] Sound continues playing when video's src is changed
Summary: [EME] Sound continues playing when video's src is changed
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-05-31 13:43 PDT by Jer Noble
Modified: 2016-06-01 23:13 PDT (History)
0 users

See Also:


Attachments
Patch (10.46 KB, patch)
2016-05-31 13:54 PDT, Jer Noble
no flags Details | Formatted Diff | Diff
Patch (10.51 KB, patch)
2016-05-31 14:04 PDT, Jer Noble
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2016-05-31 13:43:23 PDT
[EME] Sound continues playing when video's src is changed
Comment 1 Jer Noble 2016-05-31 13:54:51 PDT
Created attachment 280176 [details]
Patch
Comment 2 Jer Noble 2016-05-31 14:04:50 PDT
Created attachment 280180 [details]
Patch
Comment 3 Eric Carlson 2016-05-31 14:18:27 PDT
Comment on attachment 280180 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=280180&action=review

> Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:2598
> +    std::unique_ptr<CDMSessionAVFoundationObjC> session = std::make_unique<CDMSessionAVFoundationObjC>(this, client);

Nit: can you use "auto" here?
Comment 4 Jer Noble 2016-05-31 14:20:51 PDT
(In reply to comment #3)
> Comment on attachment 280180 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=280180&action=review
> 
> > Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:2598
> > +    std::unique_ptr<CDMSessionAVFoundationObjC> session = std::make_unique<CDMSessionAVFoundationObjC>(this, client);
> 
> Nit: can you use "auto" here?

Sure can!
Comment 5 Jer Noble 2016-05-31 14:23:07 PDT
Committed r201524: <http://trac.webkit.org/changeset/201524>
Comment 6 Jer Noble 2016-05-31 14:23:28 PDT
<rdar://problem/26248690>
Comment 7 Darin Adler 2016-06-01 23:13:19 PDT
Comment on attachment 280180 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=280180&action=review

> Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:2600
> +    return WTFMove(session);

No need for WTFMove here.